Page MenuHomePhorge
Differential D1267

Support: Awarding a bonus or penalty (Bifrost#T315896)
ClosedPublic
Actions

Authored by machniak on May 14 2020, 12:52 PM.
Tags
None
Referenced Files
F12349215: D1267.id.diff
Sun, May 26, 4:50 AM
Unknown Object (File)
Fri, May 24, 11:42 PM
Unknown Object (File)
Fri, May 24, 6:05 PM
Unknown Object (File)
Fri, May 24, 5:31 AM
Unknown Object (File)
Thu, May 23, 7:15 AM
Unknown Object (File)
Thu, May 23, 3:48 AM
Unknown Object (File)
Wed, May 22, 2:40 AM
Unknown Object (File)
Sat, May 18, 1:13 PM
View All 58 Files
Subscribers
bohlender
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896)
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/bonus-and-penalty
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29434
Build 10741: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 14 2020, 12:52 PM
machniak created this revision.
Harbormaster completed remote builds in B29401: Diff 3250.May 14 2020, 12:52 PM
bohlender subscribed.May 18 2020, 6:38 AM
bohlender added inline comments.
src/resources/vue/Admin/User.vue
302–336

We seem make more use of modals lately. I wonder if going with changing the user interface inline might provide a better user experience.
But I would not really bother for the support interface

machniak updated this revision to Diff 3271.May 18 2020, 11:38 AM

Rebase

Harbormaster completed remote builds in B29434: Diff 3271.May 18 2020, 11:38 AM
vanmeeuwen added a child revision: D1102: An initial implementation of transactions..May 28 2020, 11:46 AM
machniak updated this revision to Diff 3460.May 29 2020, 8:17 AM
  • Use transaction log
Harbormaster completed remote builds in B29632: Diff 3460.May 29 2020, 8:17 AM
machniak edited the summary of this revision. (Show Details)May 29 2020, 8:18 AM
vanmeeuwen accepted this revision.Jun 4 2020, 12:49 PM
This revision is now accepted and ready to land.Jun 4 2020, 12:49 PM
Closed by commit rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896) (authored by machniak). · Explain WhyJun 4 2020, 12:53 PM
This revision was automatically updated to reflect the committed changes.
bohlender added a comment.Jun 4 2020, 1:05 PM

Just one labeling issue were we could be clearer. The rest looks good

src/resources/vue/Admin/User.vue
139

I'd label the buttons "add bonus" / "add penalty"

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
Admin/
50 lines
resources/
lang/
en/
2 lines
vue/
Admin/
84 lines
routes/
1 line
tests/
Browser/
Admin/
101 lines
Feature/
Controller/
Admin/
50 lines

Diff 3271

View Options

src/app/Http/Controllers/API/V4/Admin/WalletsController.php

Loading...
View Options

src/resources/lang/en/app.php

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Browser/Admin/UserTest.php

Loading...
View Options

src/tests/Feature/Controller/Admin/WalletsTest.php

Loading...