Page MenuHomePhorge
Differential D152

Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try to properly detect when XFER command should be issued
ClosedPublic
Actions

Authored by machniak on May 4 2016, 11:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 7:43 PM
Unknown Object (File)
Thu, Mar 28, 9:19 PM
Unknown Object (File)
Mar 2 2024, 4:43 AM
Unknown Object (File)
Mar 2 2024, 4:43 AM
Unknown Object (File)
Mar 2 2024, 4:43 AM
Unknown Object (File)
Feb 9 2024, 1:24 PM
Unknown Object (File)
Feb 8 2024, 1:11 PM
Unknown Object (File)
Feb 7 2024, 1:21 PM
View All Files
Subscribers
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rPce96bb25f424: Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try…
rPecaeb83ca935: Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try…
Summary

Fixes #5299

Diff Detail

Repository
rP pykolab
Branch
dev/5299
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3538
Build 3513: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 314.May 4 2016, 11:23 AM
machniak retitled this revision from to Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try to properly detect when XFER command should be issued.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 4:49 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen subscribed.

Please see inline commentary.

pykolab/imap/cyrus.py
473

Why not move this up to outside the dry-run clause, and use the same if not target_server == source_server clause for the dry-run section?

This revision now requires changes to proceed.May 4 2016, 4:49 PM
machniak added inline comments.May 4 2016, 6:16 PM
pykolab/imap/cyrus.py
473

I missed that part, will fix it

machniak updated this revision to Diff 328.May 4 2016, 6:19 PM
machniak edited edge metadata.

Fix setting source folder also for dry-run mode

vanmeeuwen accepted this revision.May 6 2016, 2:23 PM
vanmeeuwen edited edge metadata.

Thanks

This revision is now accepted and ready to land.May 6 2016, 2:23 PM
Closed by commit rPecaeb83ca935: Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try… (authored by machniak, committed by vanmeeuwen). · Explain WhyMay 6 2016, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
imap/
10 lines

Diff 314

View Options

pykolab/imap/cyrus.py

Loading...