Page MenuHomePhorge
Differential D137

Prevent from AttributeError when stopping wallace
ClosedPublic
Actions

Authored by machniak on Apr 19 2016, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 4:54 PM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Wed, Apr 10, 11:56 PM
Unknown Object (File)
Wed, Apr 10, 11:46 PM
Unknown Object (File)
Fri, Mar 22, 3:13 PM
Unknown Object (File)
Fri, Mar 22, 3:12 PM
View All Files
Subscribers
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP61eeb5c09b49: Prevent from AttributeError when stopping wallace
rPed7a476d6b8e: Prevent from AttributeError when stopping wallace
Summary

Sometimes self.pool may not exists when killing wallace process

Diff Detail

Repository
rP pykolab
Branch
dev/attr-err-fix
Lint
Lint Errors
SeverityLocationCodeMessage
Errorwallace/__init__.py:42E402PEP8 E402
Errorwallace/__init__.py:44E302PEP8 E302
Errorwallace/__init__.py:49E501PEP8 E501
Errorwallace/__init__.py:67E501PEP8 E501
Errorwallace/__init__.py:70E711PEP8 E711
Errorwallace/__init__.py:75E501PEP8 E501
Errorwallace/__init__.py:82E302PEP8 E302
Errorwallace/__init__.py:91E501PEP8 E501
Errorwallace/__init__.py:99E302PEP8 E302
Errorwallace/__init__.py:100E501PEP8 E501
Errorwallace/__init__.py:102E302PEP8 E302
Errorwallace/__init__.py:111E221PEP8 E221
Errorwallace/__init__.py:111E251PEP8 E251
Errorwallace/__init__.py:111E251PEP8 E251
Errorwallace/__init__.py:112E221PEP8 E221
Errorwallace/__init__.py:112E251PEP8 E251
Errorwallace/__init__.py:112E251PEP8 E251
Errorwallace/__init__.py:113E251PEP8 E251
Errorwallace/__init__.py:113E251PEP8 E251
Errorwallace/__init__.py:114E221PEP8 E221
Errorwallace/__init__.py:114E251PEP8 E251
Errorwallace/__init__.py:114E251PEP8 E251
Errorwallace/__init__.py:119E221PEP8 E221
Errorwallace/__init__.py:119E251PEP8 E251
Errorwallace/__init__.py:119E251PEP8 E251
Unit
No Test Coverage
Build Status
Buildable 3417
Build 3392: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 287.Apr 19 2016, 11:33 AM
machniak retitled this revision from to Prevent from AttributeError when stopping wallace.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 3:59 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen subscribed.

Let's make sure that self.pool = None instead, and test for self.pool is not None right where you made your changes -- A self.pool that exists can still not have a function .close() / .join().

This revision now requires changes to proceed.May 4 2016, 3:59 PM
machniak updated this revision to Diff 321.May 4 2016, 4:21 PM
machniak edited edge metadata.

Make sure that self.pool = None instead, and test for self.pool is not None

vanmeeuwen accepted this revision.May 13 2016, 10:46 AM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 10:46 AM
Closed by commit rPed7a476d6b8e: Prevent from AttributeError when stopping wallace (authored by machniak, committed by vanmeeuwen). · Explain WhyMay 13 2016, 10:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
wallace/
5 lines

Diff 287

View Options

wallace/__init__.py

Loading...