Page MenuHomePhorge

Prevent from AttributeError when stopping wallace
ClosedPublic

Authored by machniak on Apr 19 2016, 11:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 5:58 PM
Unknown Object (File)
Fri, Apr 19, 2:48 PM
Unknown Object (File)
Sat, Apr 13, 4:54 PM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Wed, Apr 10, 11:56 PM
Unknown Object (File)
Wed, Apr 10, 11:46 PM
Subscribers

Details

Summary

Sometimes self.pool may not exists when killing wallace process

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak retitled this revision from to Prevent from AttributeError when stopping wallace.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen subscribed.

Let's make sure that self.pool = None instead, and test for self.pool is not None right where you made your changes -- A self.pool that exists can still not have a function .close() / .join().

This revision now requires changes to proceed.May 4 2016, 3:59 PM
machniak edited edge metadata.

Make sure that self.pool = None instead, and test for self.pool is not None

vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 10:46 AM
This revision was automatically updated to reflect the committed changes.