Page MenuHomePhorge
Differential D1096

Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()
ClosedPublic
Actions

Authored by vanmeeuwen on Mar 30 2020, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 1:34 PM
Unknown Object (File)
Tue, May 7, 5:31 PM
Unknown Object (File)
Sat, May 4, 5:10 AM
Unknown Object (File)
Thu, May 2, 8:57 PM
Unknown Object (File)
Thu, Apr 25, 10:43 PM
Unknown Object (File)
Sun, Apr 21, 11:43 AM
Unknown Object (File)
Apr 4 2024, 6:53 AM
Unknown Object (File)
Apr 3 2024, 6:02 AM
View All 43 Files
Subscribers
machniak
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKd163b25ee470: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()
rK2a108c7afa39: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()
Summary

Carbon::now()->subMonth(1) for 2020-03-30 will end up as 2020-03-01, which simply isn't a month.

Test Plan

phpunit failed.

apply change.

phpunit succeeds.

Diff Detail

Repository
rK kolab
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28849
Build 10426: arc lint + arc unit

Event Timeline

vanmeeuwen requested review of this revision.Mar 30 2020, 10:50 AM
vanmeeuwen created this revision.
Harbormaster completed remote builds in B28849: Diff 2830.Mar 30 2020, 10:50 AM
machniak accepted this revision.Mar 30 2020, 11:04 AM
machniak subscribed.

I'd re-check on 1st of month.

This revision is now accepted and ready to land.Mar 30 2020, 11:04 AM
Closed by commit rK2a108c7afa39: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow() (authored by vanmeeuwen). · Explain WhyMar 31 2020, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
6 lines
database/
seeds/
4 lines
tests/
Feature/
20 lines
2 lines
2 lines

Diff 2830

View Options

src/app/Wallet.php

Loading...
View Options

src/database/seeds/UserSeeder.php

Loading...
View Options

src/tests/Feature/BillingTest.php

Loading...
View Options

src/tests/Feature/EntitlementTest.php

Loading...
View Options

src/tests/Feature/SkuTest.php

Loading...