HomePhorge
Diffusion kolab 2a108c7afa39

Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()

Description

Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()

Summary: Carbon::now()->subMonth(1) for 2020-03-30 will end up as 2020-03-01, which simply isn't a month.

Test Plan:
phpunit failed.

apply change.

phpunit succeeds.

Reviewers: #hkccp_developers, machniak

Reviewed By: #hkccp_developers, machniak

Subscribers: machniak, #hkccp_developers

Differential Revision: https://git.kolab.org/D1096

Details

Provenance
vanmeeuwenAuthored on Mar 31 2020, 7:46 AM
vanmeeuwenPushed on Mar 31 2020, 7:46 AM
Reviewer
Restricted Project
Differential Revision
D1096: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()
Parents
rK3696bb7ebae8: 2FA - initial, non-working code
Branches
Unknown
Tags
Unknown
Build Status
Buildable 28873