HomePhorge
Diffusion kolab d163b25ee470

Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()
d163b25ee470Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()

Summary: Carbon::now()->subMonth(1) for 2020-03-30 will end up as 2020-03-01, which simply isn't a month.

Test Plan:
phpunit failed.

apply change.

phpunit succeeds.

Reviewers: #hkccp_developers, machniak

Reviewed By: #hkccp_developers, machniak

Subscribers: machniak, #hkccp_developers

Differential Revision: https://git.kolab.org/D1096

Details

Provenance
vanmeeuwenAuthored on Mar 31 2020, 7:46 AM
vanmeeuwenPushed on Apr 1 2020, 1:07 PM
Reviewer
Restricted Project
Differential Revision
D1096: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow()

Commit No Longer Exists

This commit no longer exists in the repository.