Details

Reviewers

vanmeeuwen

Commits

rKbd67f73b11e8: Group: Additional user (Bifrost#T249344)

Summary

TODO: email aliases, adding new users

Diff Detail

Repository

rK kolab

Branch

dev/users

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28351
Build 10129: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 25 2020, 3:53 PM

machniak created this revision.

Harbormaster completed remote builds in B28300: Diff 2374.Feb 25 2020, 3:53 PM

Email aliases (backend part)

Harbormaster completed remote builds in B28306: Diff 2380.Feb 26 2020, 2:49 PM

vanmeeuwen requested changes to this revision.Feb 26 2020, 7:04 PM

vanmeeuwen added inline comments.

src/tests/Feature/Controller/UsersTest.php

225

This assertion fails for me stating;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 17 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223

and later;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 51 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223

This revision now requires changes to proceed.Feb 26 2020, 7:04 PM

Aliases validation

Harbormaster completed remote builds in B28327: Diff 2401.Feb 27 2020, 3:48 PM

Aliases UI

Harbormaster completed remote builds in B28345: Diff 2413.Feb 28 2020, 1:10 PM

Adding new users

Harbormaster completed remote builds in B28351: Diff 2419.Feb 29 2020, 8:44 AM

UserTest feature tests do not complete successfully;

[vanmeeuwen@mws09 src (arcpatch-D976 %)]$ ./phpunit 
~/devel/src/apheleia/kolab.git/src ~/devel/src/apheleia/kolab.git/src
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

.........................................II.......I.IIIIIIIII..  63 / 154 ( 40%)
..............................I..I..I.I..................I..... 126 / 154 ( 81%)
.........II......IF

Time: 2.21 minutes, Memory: 62.50 MB

There was 1 failure:

1) Tests\Feature\UserTest::testSetAliases
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'useralias2@useraccount.com'
+'useralias@useraccount.com'

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/UserTest.php:238

FAILURES!
Tests: 145, Assertions: 1768, Failures: 1, Incomplete: 20.

Generating code coverage report in HTML format ... done
~/devel/src/apheleia/kolab.git/src

src/tests/Feature/UserTest.php
239	This ordering doesn't seem to work, or doesn't seem to work every time. Would it be better to test useralias1 and useralias2?

This revision now requires changes to proceed.Mar 2 2020, 10:38 AM

Add orderBy() so aliases list is sorted

Harbormaster completed remote builds in B28363: Diff 2425.Mar 2 2020, 10:46 AM

Eliminate aliases sorting issue

Harbormaster completed remote builds in B28369: Diff 2431.Mar 2 2020, 10:53 AM

vanmeeuwen accepted this revision.Mar 2 2020, 11:33 AM

This revision is now accepted and ready to land.Mar 2 2020, 11:33 AM

Closed by commit rKbd67f73b11e8: Group: Additional user (Bifrost#T249344) (authored by machniak). · Explain WhyMar 2 2020, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Group: Additional user (Bifrost#T249344)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2419

src/app/Http/Controllers/API/SignupController.php

src/app/Http/Controllers/API/UsersController.php

src/app/Observers/UserAliasObserver.php

src/app/Providers/AppServiceProvider.php

src/app/Rules/ExternalEmail.php

src/app/Rules/UserEmailDomain.php

src/app/Rules/UserEmailLocal.php

src/app/Traits/UserAliasesTrait.php

src/app/User.php

src/app/UserAlias.php

src/database/migrations/2020_02_26_000000_create_user_aliases_table.php

src/database/seeds/UserSeeder.php

src/resources/js/app.js

src/resources/lang/en/app.php

src/resources/lang/en/validation.php

src/resources/sass/app.scss

src/resources/vue/components/User/Info.vue

src/resources/vue/components/User/List.vue

src/tests/Browser/Components/ListInput.php

src/tests/Browser/Components/Toast.php

src/tests/Browser/Pages/UserInfo.php

src/tests/Browser/Pages/UserList.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/SignupTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/UserTest.php

src/tests/TestCase.php

src/tests/Unit/Rules/ExternalEmailTest.php

src/tests/Unit/Rules/UserEmailDomainTest.php

src/tests/Unit/Rules/UserEmailLocalTest.php

Group: Additional user (Bifrost#T249344)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2419

src/app/Http/Controllers/API/SignupController.php

src/app/Http/Controllers/API/UsersController.php

src/app/Observers/UserAliasObserver.php

src/app/Providers/AppServiceProvider.php

src/app/Rules/ExternalEmail.php

src/app/Rules/UserEmailDomain.php

src/app/Rules/UserEmailLocal.php

src/app/Traits/UserAliasesTrait.php

src/app/User.php

src/app/UserAlias.php

src/database/migrations/2020_02_26_000000_create_user_aliases_table.php

src/database/seeds/UserSeeder.php

src/resources/js/app.js

src/resources/lang/en/app.php

src/resources/lang/en/validation.php

src/resources/sass/app.scss

src/resources/vue/components/User/Info.vue

src/resources/vue/components/User/List.vue

src/tests/Browser/Components/ListInput.php

src/tests/Browser/Components/Toast.php

src/tests/Browser/Pages/UserInfo.php

src/tests/Browser/Pages/UserList.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/SignupTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/UserTest.php

src/tests/TestCase.php

src/tests/Unit/Rules/ExternalEmailTest.php

src/tests/Unit/Rules/UserEmailDomainTest.php

src/tests/Unit/Rules/UserEmailLocalTest.php

Group: Additional user (Bifrost#T249344)
ClosedPublic
Actions

Revision Contents
Changeset List