Page MenuHomePhorge

Group: Additional user (Bifrost#T249344)
ClosedPublic

Authored by machniak on Feb 25 2020, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 1:46 AM
Unknown Object (File)
Mon, Mar 18, 6:35 AM
Unknown Object (File)
Sun, Mar 17, 2:22 PM
Unknown Object (File)
Wed, Feb 28, 3:01 AM
Unknown Object (File)
Feb 26 2024, 8:46 PM
Unknown Object (File)
Feb 23 2024, 2:05 AM
Unknown Object (File)
Feb 22 2024, 4:41 PM
Unknown Object (File)
Feb 15 2024, 12:04 AM
Subscribers
None

Details

Summary

TODO: email aliases, adding new users

Diff Detail

Repository
rK kolab
Branch
dev/users
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28306
Build 10090: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Email aliases (backend part)
vanmeeuwen added inline comments.
src/tests/Feature/Controller/UsersTest.php
223

This assertion fails for me stating;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 17 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223

and later;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 51 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223
This revision now requires changes to proceed.Feb 26 2020, 7:04 PM

UserTest feature tests do not complete successfully;

[vanmeeuwen@mws09 src (arcpatch-D976 %)]$ ./phpunit 
~/devel/src/apheleia/kolab.git/src ~/devel/src/apheleia/kolab.git/src
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

.........................................II.......I.IIIIIIIII..  63 / 154 ( 40%)
..............................I..I..I.I..................I..... 126 / 154 ( 81%)
.........II......IF

Time: 2.21 minutes, Memory: 62.50 MB

There was 1 failure:

1) Tests\Feature\UserTest::testSetAliases
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'useralias2@useraccount.com'
+'useralias@useraccount.com'

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/UserTest.php:238

FAILURES!
Tests: 145, Assertions: 1768, Failures: 1, Incomplete: 20.

Generating code coverage report in HTML format ... done
~/devel/src/apheleia/kolab.git/src
src/tests/Feature/UserTest.php
210

This ordering doesn't seem to work, or doesn't seem to work every time.

Would it be better to test useralias1 and useralias2?

This revision now requires changes to proceed.Mar 2 2020, 10:38 AM
  • Add orderBy() so aliases list is sorted
  • Eliminate aliases sorting issue
This revision is now accepted and ready to land.Mar 2 2020, 11:33 AM
This revision was automatically updated to reflect the committed changes.