Page MenuHomePhorge
Differential D581

Fix D577 patch bug - modules._sendmail result assign to variable, which is used to log the result of email sending.
ClosedPublic
Actions

Authored by adomaitis on May 25 2018, 8:07 AM.
Tags
None
Referenced Files
F11804403: D581.id1430.diff
Fri, Apr 19, 7:23 AM
F11804385: D581.id.diff
Fri, Apr 19, 7:21 AM
F11803638: D581.id1424.diff
Fri, Apr 19, 6:20 AM
F11799942: D581.id1407.diff
Fri, Apr 19, 1:11 AM
Unknown Object (File)
Wed, Apr 17, 2:16 PM
Unknown Object (File)
Wed, Apr 17, 11:24 AM
Unknown Object (File)
Mon, Apr 15, 8:49 AM
Unknown Object (File)
Fri, Apr 12, 11:40 PM
View All 67 Files
Subscribers
petersen

Details

Reviewers
vanmeeuwen
machniak
Commits
rP46f61ab9984e: Fix D577 patch bug - modules._sendmail result assign to variable, which is used…
Summary

Define success variable to hold the _sendmail result.

Test Plan

none

Diff Detail

Repository
rP pykolab
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 18599
Build 9447: arc lint + arc unit

Event Timeline

adomaitis created this revision.May 25 2018, 8:07 AM
machniak requested changes to this revision.May 25 2018, 8:15 AM
machniak added inline comments.
wallace/module_invitationpolicy.py
1287

A typo here, you've cut m

This revision now requires changes to proceed.May 25 2018, 8:15 AM
adomaitis updated this revision to Diff 1407.May 25 2018, 8:23 AM

Fix typo

machniak accepted this revision.May 25 2018, 8:24 AM
This revision is now accepted and ready to land.May 25 2018, 8:24 AM
adomaitis updated this revision to Diff 1424.Jun 4 2018, 10:33 AM
adomaitis marked an inline comment as done.

Getting rid of all smtplib calls and make all email sending via modules._sendmail

machniak accepted this revision.Jun 4 2018, 11:45 AM
Closed by commit rP46f61ab9984e: Fix D577 patch bug - modules._sendmail result assign to variable, which is used… (authored by adomaitis). · Explain WhyJun 4 2018, 1:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
wallace/
4 lines

Diff 1407

View Options

wallace/module_invitationpolicy.py

Loading...