Paths

Table of Contentst

Fix D577 patch bug - modules._sendmail result assign to variable, which is used to log the result of email sending.
ClosedPublic
Actions

Authored by adomaitis on May 25 2018, 8:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 8:49 AM

	Unknown Object (File)
	Fri, Apr 12, 11:40 PM

	Unknown Object (File)
	Tue, Apr 9, 10:02 PM

	Unknown Object (File)
	Tue, Apr 9, 8:50 PM

	Unknown Object (File)
	Mon, Apr 8, 11:56 AM

	Unknown Object (File)
	Wed, Apr 3, 1:36 PM

	Unknown Object (File)
	Wed, Apr 3, 1:36 PM

	Unknown Object (File)
	Wed, Apr 3, 1:36 PM

View All 61 Files

Subscribers

petersen

Details

Reviewers

vanmeeuwen
machniak

Commits

rP46f61ab9984e: Fix D577 patch bug - modules._sendmail result assign to variable, which is used…

Summary

Define success variable to hold the _sendmail result.

Test Plan

none

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adomaitis created this revision.May 25 2018, 8:07 AM

machniak requested changes to this revision.May 25 2018, 8:15 AM

machniak added inline comments.

wallace/module_invitationpolicy.py
1286	A typo here, you've cut `m`

This revision now requires changes to proceed.May 25 2018, 8:15 AM

Fix typo

machniak accepted this revision.May 25 2018, 8:24 AM

This revision is now accepted and ready to land.May 25 2018, 8:24 AM

Getting rid of all smtplib calls and make all email sending via modules._sendmail

machniak accepted this revision.Jun 4 2018, 11:45 AM

Closed by commit rP46f61ab9984e: Fix D577 patch bug - modules._sendmail result assign to variable, which is used… (authored by adomaitis). · Explain WhyJun 4 2018, 1:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

wallace/

module_invitationpolicy.py

6 lines

module_resources.py

13 lines

Diff 1430

View Options

wallace/module_invitationpolicy.py