Page MenuHomePhorge
Differential D4217

Log spf failure reasons
Needs ReviewPublic
Actions

Authored by mollekopf on Mar 27 2023, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 10:27 AM
Unknown Object (File)
Sat, Apr 13, 11:14 AM
Unknown Object (File)
Sat, Apr 6, 7:42 PM
Unknown Object (File)
Sun, Mar 31, 8:29 PM
Unknown Object (File)
Thu, Mar 28, 4:06 PM
Unknown Object (File)
Mar 6 2024, 11:44 AM
Unknown Object (File)
Mar 6 2024, 11:44 AM
Unknown Object (File)
Mar 6 2024, 11:44 AM
View All 70 Files
Subscribers
None

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rKbf6ce32db9a4: Log spf failure reasons
rKd20cae4db493: Log spf failure reasons
rK69cb60c404b3: Log spf failure reasons
rKa4376ef8cc9a: Log spf failure reasons
rK1fadd19ab912: Log spf failure reasons
rK8c498c209533: Log spf failure reasons
rK9ffc552afb6b: Log spf failure reasons
rK89f90ef79ba5: Log spf failure reasons
rK7876cde310e0: Log spf failure reasons
rK46e43d87799f: Log spf failure reasons
rK7afdd11f3596: Log spf failure reasons
rK1f12c094284f: Log spf failure reasons
Summary

We should probably do the same with greylisting/ratelimiting

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/app/Http/Controllers/API/V4/PolicyController.php:302PHP1Parse Error
Errorsrc/app/Http/Controllers/API/V4/PolicyController.php:302phpstanSyntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ']' or ')' on line 302
Errorsrc/app/Http/Controllers/API/V4/PolicyController.php:318phpstanSyntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ']' or ')' on line 318
Unit
No Test Coverage
Build Status
Buildable 42224
Build 17030: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 27 2023, 11:48 AM
mollekopf created this revision.
Harbormaster completed remote builds in B42179: Diff 12074.Mar 27 2023, 11:48 AM
mollekopf added a reviewer: Restricted Project.Mar 27 2023, 11:48 AM
mollekopf updated this revision to Diff 12107.Mar 27 2023, 4:01 PM

Don't change the string we send to the client
Log to syslog

I can't test the logging because I don't have syslog it seems?

Harbormaster completed remote builds in B42224: Diff 12107.Mar 27 2023, 4:01 PM
mollekopf updated this revision to Diff 12110.Mar 27 2023, 4:03 PM

Fixup

Harbormaster completed remote builds in B42227: Diff 12110.Mar 27 2023, 4:03 PM

Revision Contents
Changeset List

PathSize
extras/
13 lines
src/
app/
Http/
Controllers/
API/
V4/
2 lines

Diff 12107

View Options

extras/kolab_policy_spf

Loading...
View Options

src/app/Http/Controllers/API/V4/PolicyController.php

Loading...