Differential D4217

Log spf failure reasons
ClosedPublic
Actions

Authored by mollekopf on Mar 27 2023, 11:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 25, 4:14 AM

	Unknown Object (File)
	Sat, Jul 20, 3:36 AM

	Unknown Object (File)
	Sun, Jul 14, 7:47 PM

	Unknown Object (File)
	Thu, Jul 11, 6:26 AM

	Unknown Object (File)
	Wed, Jul 10, 11:47 PM

	Unknown Object (File)
	Wed, Jul 10, 5:37 AM

	Unknown Object (File)
	Sat, Jul 6, 2:19 AM

	Unknown Object (File)
	Sun, Jun 30, 8:02 AM

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK3cae85929a7a: Log spf failure reasons
rKbf6ce32db9a4: Log spf failure reasons
rKd20cae4db493: Log spf failure reasons
rK69cb60c404b3: Log spf failure reasons
rKa4376ef8cc9a: Log spf failure reasons
rK1fadd19ab912: Log spf failure reasons
rK8c498c209533: Log spf failure reasons
rK9ffc552afb6b: Log spf failure reasons
rK89f90ef79ba5: Log spf failure reasons
rK7876cde310e0: Log spf failure reasons
rK46e43d87799f: Log spf failure reasons
rK7afdd11f3596: Log spf failure reasons
rK1f12c094284f: Log spf failure reasons

Summary

We should probably do the same with greylisting/ratelimiting

Diff Detail

Repository

Branch

dev/mollekopf

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/app/Http/Controllers/API/V4/PolicyController.php:302	PHP1	Parse Error
Error	src/app/Http/Controllers/API/V4/PolicyController.php:302	phpstan	Syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ']' or ')' on line 302
Error	src/app/Http/Controllers/API/V4/PolicyController.php:318	phpstan	Syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ']' or ')' on line 318

Unit

No Test Coverage

Build Status

Buildable 42224
Build 17030: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 27 2023, 11:48 AM

mollekopf created this revision.

Harbormaster completed remote builds in B42179: Diff 12074.Mar 27 2023, 11:48 AM

mollekopf added a reviewer: Restricted Project.Mar 27 2023, 11:48 AM

Don't change the string we send to the client
Log to syslog

I can't test the logging because I don't have syslog it seems?

Harbormaster completed remote builds in B42224: Diff 12107.Mar 27 2023, 4:01 PM

Fixup

Harbormaster completed remote builds in B42227: Diff 12110.Mar 27 2023, 4:03 PM

machniak accepted this revision.May 21 2024, 10:49 AM

This revision is now accepted and ready to land.May 21 2024, 10:49 AM

Closed by commit rK3cae85929a7a: Log spf failure reasons (authored by mollekopf). · Explain WhyJun 12 2024, 2:34 PM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK3cae85929a7a: Log spf failure reasons.

Revision Contents
Changeset List

Path

Size

extras/

kolab_policy_spf

13 lines

src/

app/

Http/

Controllers/

API/

V4/

PolicyController.php

2 lines

Diff 12107

extras/kolab_policy_spf

Loading...

src/app/Http/Controllers/API/V4/PolicyController.php

Loading...