Page MenuHomePhorge
Differential D3544

Lists code de-duplication
ClosedPublic
Actions

Authored by machniak on May 3 2022, 12:51 PM.
Tags
None
Referenced Files
F11957463: D3544.id10174.diff
Wed, May 1, 4:39 AM
F11952135: D3544.id10259.diff
Tue, Apr 30, 11:36 AM
F11952132: D3544.id10247.diff
Tue, Apr 30, 11:36 AM
F11952126: D3544.id10217.diff
Tue, Apr 30, 11:36 AM
F11952123: D3544.id10174.diff
Tue, Apr 30, 11:36 AM
F11952120: D3544.id10168.diff
Tue, Apr 30, 11:35 AM
F11952117: D3544.id.diff
Tue, Apr 30, 11:35 AM
Unknown Object (File)
Tue, Apr 23, 1:17 AM
View All 54 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK7afda1c639ab: Lists code de-duplication
Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Branch
dev/lists-deduplication
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 39110
Build 15887: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 3 2022, 12:51 PM
machniak created this revision.
Harbormaster completed remote builds in B39052: Diff 10168.May 3 2022, 12:51 PM
machniak updated this revision to Diff 10174.May 4 2022, 9:21 AM
  • More code de-duplication
  • More code de-duplication
  • cols -> columns
Harbormaster completed remote builds in B39058: Diff 10174.May 4 2022, 9:21 AM
machniak updated this revision to Diff 10217.May 10 2022, 2:59 PM
  • Fix linting errors
Harbormaster completed remote builds in B39095: Diff 10217.May 10 2022, 2:59 PM
mollekopf subscribed.May 18 2022, 3:27 PM

This patch doesn't apply on top of master with the other patches as specified in the ticket.

machniak updated this revision to Diff 10247.May 19 2022, 1:48 PM

fix

Harbormaster completed remote builds in B39110: Diff 10247.May 19 2022, 1:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 2:46 PM
Closed by commit rK7afda1c639ab: Lists code de-duplication (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
resources/
lang/
en/
8 lines
fr/
6 lines
themes/
7 lines
vue/
Admin/
32 lines
196 lines
Distlist/
29 lines
39 lines
Domain/
25 lines
35 lines
Reseller/
63 lines
Resource/
29 lines
39 lines
SharedFolder/
30 lines
47 lines
User/
21 lines
32 lines
Widgets/
33 lines
61 lines

Diff 10247

View Options

src/resources/lang/en/ui.php

Loading...
View Options

src/resources/lang/fr/ui.php

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/vue/Admin/SharedFolder.vue

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/resources/vue/Distlist/List.vue

Loading...
View Options

src/resources/vue/Distlist/ListWidget.vue

Loading...
View Options

src/resources/vue/Domain/List.vue

Loading...
View Options

src/resources/vue/Domain/ListWidget.vue

Loading...
View Options

src/resources/vue/Reseller/Invitations.vue

Loading...
View Options

src/resources/vue/Resource/List.vue

Loading...
View Options

src/resources/vue/Resource/ListWidget.vue

Loading...
View Options

src/resources/vue/SharedFolder/List.vue

Loading...
View Options

src/resources/vue/SharedFolder/ListWidget.vue

Loading...
View Options

src/resources/vue/User/List.vue

Loading...
View Options

src/resources/vue/User/ListWidget.vue

Loading...
View Options

src/resources/vue/Widgets/CompanionappList.vue

Loading...
View Options

src/resources/vue/Widgets/ListTools.vue

Loading...