Page MenuHomekolab.org

Group: Additional user (Bifrost#T249344)
ClosedPublic

Authored by machniak on Feb 25 2020, 3:53 PM.

Details

Summary

TODO: email aliases, adding new users

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Feb 25 2020, 3:53 PM
machniak created this revision.
machniak updated this revision to Diff 2380.Feb 26 2020, 2:49 PM
  • Email aliases (backend part)
vanmeeuwen requested changes to this revision.Feb 26 2020, 7:04 PM
vanmeeuwen added inline comments.
src/tests/Feature/Controller/UsersTest.php
225

This assertion fails for me stating;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 17 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223

and later;

1) Tests\Feature\Controller\UsersTest::testUserResponse
Failed asserting that 51 matches expected 1.

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/Controller/UsersTest.php:223
This revision now requires changes to proceed.Feb 26 2020, 7:04 PM
machniak updated this revision to Diff 2401.Feb 27 2020, 3:48 PM
  • Aliases validation
machniak updated this revision to Diff 2413.Feb 28 2020, 1:10 PM
  • Aliases UI
machniak updated this revision to Diff 2419.Feb 29 2020, 8:44 AM
  • Adding new users
vanmeeuwen requested changes to this revision.Mar 2 2020, 10:38 AM

UserTest feature tests do not complete successfully;

[vanmeeuwen@mws09 src (arcpatch-D976 %)]$ ./phpunit 
~/devel/src/apheleia/kolab.git/src ~/devel/src/apheleia/kolab.git/src
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

.........................................II.......I.IIIIIIIII..  63 / 154 ( 40%)
..............................I..I..I.I..................I..... 126 / 154 ( 81%)
.........II......IF

Time: 2.21 minutes, Memory: 62.50 MB

There was 1 failure:

1) Tests\Feature\UserTest::testSetAliases
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'useralias2@useraccount.com'
+'useralias@useraccount.com'

/home/vanmeeuwen/devel/src/apheleia/kolab.git/src/tests/Feature/UserTest.php:238

FAILURES!
Tests: 145, Assertions: 1768, Failures: 1, Incomplete: 20.

Generating code coverage report in HTML format ... done
~/devel/src/apheleia/kolab.git/src
src/tests/Feature/UserTest.php
239

This ordering doesn't seem to work, or doesn't seem to work every time.

Would it be better to test useralias1 and useralias2?

This revision now requires changes to proceed.Mar 2 2020, 10:38 AM
machniak updated this revision to Diff 2425.Mar 2 2020, 10:46 AM
  • Add orderBy() so aliases list is sorted
machniak updated this revision to Diff 2431.Mar 2 2020, 10:53 AM
  • Eliminate aliases sorting issue
vanmeeuwen accepted this revision.Mar 2 2020, 11:33 AM
This revision is now accepted and ready to land.Mar 2 2020, 11:33 AM
This revision was automatically updated to reflect the committed changes.