Page MenuHomePhorge

Changes required for pykolab to work with AD
ClosedPublic

Authored by adomaitis on Mar 5 2019, 3:17 PM.
Referenced Files
Unknown Object (File)
Wed, Mar 27, 1:32 PM
Unknown Object (File)
Mon, Mar 25, 2:57 AM
Unknown Object (File)
Sun, Mar 24, 6:12 PM
Unknown Object (File)
Wed, Feb 28, 2:59 AM
Unknown Object (File)
Feb 7 2024, 11:34 AM
Unknown Object (File)
Feb 6 2024, 1:34 PM
Unknown Object (File)
Jan 28 2024, 1:13 PM
Unknown Object (File)
Jan 28 2024, 4:52 AM

Details

Summary

These changes basically are to remove referrals from the ldapsearch results. The change is cache sqlite DB schema is required to allow objectGUID AD attribute to work as unique attribute to track LDAP objects.

Diff Detail

Repository
rP pykolab
Branch
Changes_for_AD
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22905
Build 9525: arc lint + arc unit

Event Timeline

adomaitis added a project: PyKolab.
adomaitis added a subscriber: PyKolab Developers.
  • Use python UUID to convert binary objectGUID to string. This way dont need to chage cache db format. It doesn't look like value of uniqueid returned by from cache is used anywhere (needs to double check), so only forward conversion is needed.
  • Use python UUID to convert binary objectGUID to string. It doesn't look like value of uniqueid returned by from cache is used anywhere (needs to double check), so only forward conversion is needed.
  • Also do not strip anything from bytestring attributes (objectGUID) because after stripping conversion to UUID string is not possible.
machniak requested changes to this revision.Apr 2 2019, 3:27 PM
machniak added inline comments.
pykolab/auth/ldap/__init__.py
1256

s/_entry_id/_entry_dn/, but...

This revision now requires changes to proceed.Apr 2 2019, 3:27 PM
pykolab/auth/ldap/__init__.py
1258

... but, didn't you change the returned value format? Maybe you meant _entry_dns.append(_result) in the loop above?

  • Use python UUID to convert binary objectGUID to string. It doesn't look like value of uniqueid returned by from cache is used anywhere (needs to double check), so only forward conversion is needed.

Good catch. Here is even more pythonic way removing AD referrals from ldap search results.

This revision is now accepted and ready to land.Apr 3 2019, 8:10 AM
This revision was automatically updated to reflect the committed changes.