Fix D577 patch bug - modules._sendmail result assign to variable, which is used to log the result of email sending.
ClosedPublic

Authored by adomaitis on May 25 2018, 8:07 AM.

Details

Summary

Define success variable to hold the _sendmail result.

Test Plan

none

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adomaitis created this revision.May 25 2018, 8:07 AM
machniak requested changes to this revision.May 25 2018, 8:15 AM
machniak added inline comments.
wallace/module_invitationpolicy.py
1286

A typo here, you've cut m

This revision now requires changes to proceed.May 25 2018, 8:15 AM
machniak accepted this revision.May 25 2018, 8:24 AM
This revision is now accepted and ready to land.May 25 2018, 8:24 AM
adomaitis updated this revision to Diff 1424.Jun 4 2018, 10:33 AM
adomaitis marked an inline comment as done.

Getting rid of all smtplib calls and make all email sending via modules._sendmail

machniak accepted this revision.Jun 4 2018, 11:45 AM
This revision was automatically updated to reflect the committed changes.