Page MenuHomePhorge

Support for multiple admin/reseller/services domains, don't require a specific root domain
AbandonedPublic

Authored by mollekopf on Mon, Mar 18, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 9:30 PM
Unknown Object (File)
Wed, Apr 3, 12:30 AM
Unknown Object (File)
Wed, Apr 3, 12:30 AM
Unknown Object (File)
Tue, Apr 2, 3:48 PM
Unknown Object (File)
Mon, Apr 1, 3:55 PM
Unknown Object (File)
Wed, Mar 27, 4:26 PM
Unknown Object (File)
Wed, Mar 27, 11:07 AM
Unknown Object (File)
Mon, Mar 25, 5:42 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

In kubernetes internal services communicate to other services via that internal services name (.e.g "kolab"), instead of the public name (e.g. "kolab.local").
We want this so internal traffic remains internal, and doesnt involve external dns lookups (and thus create a dependency on these external dns records) or redirect traffic outside.

However, because the api requires a single specific domain name, this doesn't work.

This affects for instance:

  • The kolab 4 files API that is contacted by chwala from both the pod and from outside (FILEAPI_KOLABFILES_BASEURI)
  • All services. endpoints. For the most part we can use APP_SERVICES_DOMAIN to just set it to e.g. "kolab" instead of "services.kolab.local", this would however become a problem if some parts outside of the cluster need to contact services.kolab.local.

The admin./reseller. subdomains are not problematic as long as we only access them from the outside.

By removing the WEBSITE_DOMAIN routing we aren't loosing much IMO. The domain by definition is publicly accessible, so we arent changing much, so we just need to make sure that the admin. and reseller. domains are picked before the website domain paths when both are an option.

This patch adds support for specifying all subdomains as a list,
primarily for consistency. We expect to use it at least for the services
domain.

Diff Detail

Repository
rK kolab
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 46803
Build 17901: arc lint + arc unit

Event Timeline

mollekopf created this revision.

I'm not sure I understand the issue. Instead of 3 config options can't we create a single one?

I'm not sure I understand the issue. Instead of 3 config options can't we create a single one

We can create just the services_domains and forego the admin_domains/reseller_domains for now, and add them once we really need them.
Is that what you mean?

In favor of the middleware based approach.