Page MenuHomePhorge
Differential D4259

Minimize race-condition on wallet balance update
ClosedPublic
Actions

Authored by machniak on Apr 12 2023, 3:12 PM.
Tags
None
Referenced Files
F12050514: D4259.diff
Tue, May 7, 3:30 PM
Unknown Object (File)
Sun, May 5, 2:44 AM
Unknown Object (File)
Sun, Apr 28, 9:09 PM
Unknown Object (File)
Wed, Apr 17, 10:32 AM
Unknown Object (File)
Wed, Apr 17, 10:32 AM
Unknown Object (File)
Wed, Apr 17, 10:32 AM
Unknown Object (File)
Wed, Apr 17, 10:31 AM
Unknown Object (File)
Wed, Apr 17, 10:31 AM
View All 89 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK7c7ecf07dbfc: Minimize race-condition on wallet balance update
Summary

Reference: T800422

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/balance-update-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 42425
Build 17138: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 12 2023, 3:12 PM
machniak created this revision.
Harbormaster completed remote builds in B42425: Diff 12227.Apr 12 2023, 3:12 PM
machniak updated this revision to Diff 12233.Apr 13 2023, 12:57 PM
  • Fix the race-condition in wallet:charge instead
Harbormaster completed remote builds in B42440: Diff 12233.Apr 13 2023, 12:57 PM
machniak updated this revision to Diff 12239.Apr 13 2023, 1:06 PM
  • Add sanity check after refresh
Harbormaster completed remote builds in B42446: Diff 12239.Apr 13 2023, 1:06 PM
vanmeeuwen accepted this revision.Apr 13 2023, 1:34 PM
This revision is now accepted and ready to land.Apr 13 2023, 1:34 PM
Closed by commit rK7c7ecf07dbfc: Minimize race-condition on wallet balance update (authored by machniak). · Explain WhyApr 13 2023, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Providers/
2 lines
4 lines
tests/
Feature/
29 lines

Diff 12227

View Options

src/app/Providers/PaymentProvider.php

Loading...
View Options

src/app/Wallet.php

Loading...
View Options

src/tests/Feature/WalletTest.php

Loading...