Paths

Table of Contentst

Fix wallet:transactions and add --balance option
ClosedPublic
Actions

Authored by machniak on Mar 20 2023, 12:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 11, 8:18 AM

	Unknown Object (File)
	Sep 13 2024, 8:40 AM

	Unknown Object (File)
	Sep 13 2024, 8:39 AM

	Unknown Object (File)
	Sep 11 2024, 11:17 AM

	Unknown Object (File)
	Aug 30 2024, 6:47 AM

	Unknown Object (File)
	Aug 28 2024, 5:04 AM

	Unknown Object (File)
	Aug 22 2024, 6:08 AM

	Unknown Object (File)
	Aug 20 2024, 5:45 AM

View All 93 Files

Subscribers

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK3a781200cc1f: Fix wallet:transactions and add --balance option

Summary

->each() without ->get() does set "LIMIT 1000 OFFSET 0" on the query. We use cursor() instead.
Added option to print wallet balance after every transaction

Test Plan

./phpunit tests/Feature/Console/Wallet/TransactionTest.php

Diff Detail

Repository

rK kolab

Branch

dev/fix-wallet-transactions-command

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 42032
Build 16883: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 20 2023, 12:38 PM

machniak created this revision.

Harbormaster completed remote builds in B42032: Diff 11909.Mar 20 2023, 12:38 PM

mollekopf accepted this revision.Mar 22 2023, 9:18 AM

This revision is now accepted and ready to land.Mar 22 2023, 9:18 AM

Closed by commit rK3a781200cc1f: Fix wallet:transactions and add --balance option (authored by machniak). · Explain WhyMar 27 2023, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Wallet/

TransactionsCommand.php

17 lines

tests/

Feature/

Console/

Wallet/

TransactionsTest.php

55 lines

Diff 11909

View Options

src/app/Console/Commands/Wallet/TransactionsCommand.php