Page MenuHomePhorge
Differential D4163

Fix wallet:transactions and add --balance option
ClosedPublic
Actions

Authored by machniak on Mar 20 2023, 12:38 PM.
Tags
None
Referenced Files
F12094914: D4163.diff
Wed, May 8, 11:58 PM
F12094317: D4163.id12092.diff
Wed, May 8, 9:56 PM
Unknown Object (File)
Sun, Apr 21, 5:09 PM
Unknown Object (File)
Sun, Apr 21, 5:09 PM
Unknown Object (File)
Sun, Apr 21, 5:09 PM
Unknown Object (File)
Thu, Apr 18, 12:09 AM
Unknown Object (File)
Wed, Apr 17, 10:20 AM
Unknown Object (File)
Apr 3 2024, 11:38 AM
View All 57 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK3a781200cc1f: Fix wallet:transactions and add --balance option
Summary
  1. ->each() without ->get() does set "LIMIT 1000 OFFSET 0" on the query. We use cursor() instead.
  2. Added option to print wallet balance after every transaction
Test Plan

./phpunit tests/Feature/Console/Wallet/TransactionTest.php

Diff Detail

Repository
rK kolab
Branch
dev/fix-wallet-transactions-command
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 42032
Build 16883: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 20 2023, 12:38 PM
machniak created this revision.
Harbormaster completed remote builds in B42032: Diff 11909.Mar 20 2023, 12:38 PM
mollekopf accepted this revision.Mar 22 2023, 9:18 AM
This revision is now accepted and ready to land.Mar 22 2023, 9:18 AM
Closed by commit rK3a781200cc1f: Fix wallet:transactions and add --balance option (authored by machniak). · Explain WhyMar 27 2023, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Wallet/
17 lines
tests/
Feature/
Console/
Wallet/
55 lines

Diff 11909

View Options

src/app/Console/Commands/Wallet/TransactionsCommand.php

Loading...
View Options

src/tests/Feature/Console/Wallet/TransactionsTest.php

Loading...