Page MenuHomePhorge
Differential D3319

Password Policy
ClosedPublic
Actions

Authored by machniak on Jan 25 2022, 11:59 AM.
Tags
None
Referenced Files
F10353973: D3319.id9499.diff
Thu, Sep 28, 2:29 AM
Unknown Object (File)
Thu, Sep 21, 10:44 AM
Unknown Object (File)
Fri, Sep 8, 9:49 PM
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK9ae41aa9253e: Password Policy
Summary

This is done on top of D3301: Password reset link

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/password-policy
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38062
Build 15406: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 25 2022, 11:59 AM
machniak created this revision.
Harbormaster completed remote builds in B38062: Diff 9430.Jan 25 2022, 11:59 AM
mollekopf accepted this revision.Jan 26 2022, 1:13 PM
mollekopf subscribed.
mollekopf added inline comments.
src/database/migrations/2022_01_13_100000_verification_code_active_column.php
32

doesn't belong in here?

This revision is now accepted and ready to land.Jan 26 2022, 1:13 PM
machniak added inline comments.Jan 26 2022, 2:21 PM
src/database/migrations/2022_01_13_100000_verification_code_active_column.php
32

Well, it does not hurt either. While doing migrate:refresh (which I do quite often) I encountered a failure, because it tried to modify a table that didn't exist.

machniak updated this revision to Diff 9487.Jan 27 2022, 2:36 PM
  • Change password policy checker icons
  • Make sure password policy can't set min/max length to smaller/greater value than the system settings
Harbormaster completed remote builds in B38137: Diff 9487.Jan 27 2022, 2:36 PM
Harbormaster completed remote builds in B38137: Diff 9487.
Closed by commit rK9ae41aa9253e: Password Policy (authored by machniak). · Explain WhyJan 27 2022, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
app/
Http/
Controllers/
API/
66 lines
28 lines
3 lines
V4/
12 lines
Rules/
188 lines
Traits/
20 lines
19 lines
config/
2 lines
database/
migrations/
4 lines
resources/
js/
6 lines
2 lines
user/
7 lines
lang/
en/
6 lines
2 lines
2 lines
themes/
1 line
vue/
3 lines
27 lines
79 lines
21 lines
User/
13 lines
22 lines
Widgets/
94 lines
routes/
3 lines
tests/
Browser/
Pages/
44 lines
86 lines
100 lines
47 lines
34 lines
19 lines
Feature/
Controller/
133 lines
35 lines
33 lines
63 lines
20 lines
64 lines
Unit/
Rules/
182 lines

Diff 9430

View Options

src/.env.example

Loading...
View Options

src/app/Http/Controllers/API/PasswordPolicyController.php

Loading...
View Options

src/app/Http/Controllers/API/PasswordResetController.php

Loading...
View Options

src/app/Http/Controllers/API/SignupController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/Rules/Password.php

Loading...
View Options

src/app/Traits/EntitleableTrait.php

Loading...
View Options

src/app/Traits/UserConfigTrait.php

Loading...
View Options

src/config/app.php

Loading...
View Options

src/database/migrations/2022_01_13_100000_verification_code_active_column.php

Loading...
View Options

src/resources/js/app.js

Loading...
View Options

src/resources/js/fontawesome.js

Loading...
View Options

src/resources/js/user/routes.js

Loading...
View Options

src/resources/lang/en/app.php

Loading...
View Options

src/resources/lang/en/ui.php

Loading...
View Options

src/resources/lang/en/validation.php

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/vue/Dashboard.vue

Loading...
View Options

src/resources/vue/PasswordReset.vue

Loading...
View Options

src/resources/vue/Settings.vue

Loading...
View Options

src/resources/vue/Signup.vue

Loading...
View Options

src/resources/vue/User/Info.vue

Loading...
View Options

src/resources/vue/User/Profile.vue

Loading...
View Options

src/resources/vue/Widgets/PasswordInput.vue

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Browser/Pages/Settings.php

Loading...
View Options

src/tests/Browser/PasswordResetTest.php

Loading...
View Options

src/tests/Browser/SettingsTest.php

Loading...
View Options

src/tests/Browser/SignupTest.php

Loading...
View Options

src/tests/Browser/UserProfileTest.php

Loading...
View Options

src/tests/Browser/UsersTest.php

Loading...
View Options

src/tests/Feature/Controller/PasswordPolicyTest.php

Loading...
View Options

src/tests/Feature/Controller/PasswordResetTest.php

Loading...
View Options

src/tests/Feature/Controller/SignupTest.php

Loading...
View Options

src/tests/Feature/Controller/UsersTest.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...
View Options

src/tests/Unit/Rules/PasswordTest.php

Loading...