.arclint config
ClosedPublic
Actions

Authored by mollekopf on Jan 12 2022, 12:13 AM.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

Summary

Includes a linter from https://github.com/appsinet/arc-phpstan (modified
for a 1GB memory limit)

Repository

rK kolab

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 38104
Build 15415: arc lint + arc unit

mollekopf requested review of this revision.Jan 12 2022, 12:13 AM

mollekopf created this revision.

mollekopf added a reviewer: Restricted Project.Jan 12 2022, 12:20 AM

mollekopf added a subscriber: Restricted Project.

I'd prefer .arc folder instead of phabricator.

Moved phabricator to .arc

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

.arclint
19	Level=6 is too high, we're using level=4 right now.

In D3289#39604, @machniak wrote:

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

It's relatively painless because it only lints the diff, not everything.
Also, you can skip it if you really want using --nolint

Addressed comments

mollekopf marked an inline comment as done.Jan 25 2022, 5:32 PM

This revision is now accepted and ready to land.Jan 25 2022, 6:18 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	.arc/arc-phpstan/__phutil_library_init__.php (18 lines)
A	M	.arc/arc-phpstan/__phutil_library_map__.php (18 lines)
A	M	.arc/arc-phpstan/lint/linter/PhpstanLinter.php (242 lines)
A	M	.arc/src/extensions/PhpstanLinter.php (242 lines)
M		.arcconfig (3 lines)
A	M	.arclint (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9352	8cebc59		Jan 12 2022, 12:13 AM	★	★
Diff 2	9406	6b7718b	Moved phabricator to .arc	Jan 18 2022, 2:36 PM	★	★
Diff 3	9463	847a2ca	Addressed comments	Jan 25 2022, 5:32 PM	★	★
Diff 4	9475	847a2ca	rK094651257b1d0522e23b3b5f333bb3206c46b813	Jan 25 2022, 3:55 PM	★	★