Page MenuHomekolab.org

.arclint config
ClosedPublic

Authored by mollekopf on Jan 12 2022, 12:13 AM.

Details

Summary

Includes a linter from https://github.com/appsinet/arc-phpstan (modified
for a 1GB memory limit)

Diff Detail

Repository
rK kolab
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 38104
Build 15415: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jan 12 2022, 12:13 AM
mollekopf created this revision.
Harbormaster completed remote builds in B37951: Diff 9352.
mollekopf added a reviewer: Restricted Project.Jan 12 2022, 12:20 AM
mollekopf added a subscriber: Restricted Project.

I'd prefer .arc folder instead of phabricator.

mollekopf updated this revision to Diff 9406.Jan 18 2022, 2:36 PM

Moved phabricator to .arc

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

.arclint
19

Level=6 is too high, we're using level=4 right now.

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

It's relatively painless because it only lints the diff, not everything.
Also, you can skip it if you really want using --nolint

mollekopf updated this revision to Diff 9463.Jan 25 2022, 5:32 PM

Addressed comments

mollekopf marked an inline comment as done.Jan 25 2022, 5:32 PM
machniak accepted this revision.Jan 25 2022, 6:18 PM
This revision is now accepted and ready to land.Jan 25 2022, 6:18 PM
This revision was automatically updated to reflect the committed changes.