Page MenuHomePhorge
Differential D3289

.arclint config
ClosedPublic
Actions

Authored by mollekopf on Jan 12 2022, 12:13 AM.
Tags
None
Referenced Files
F11809161: D3289.id9352.diff
Fri, Apr 19, 1:36 PM
Unknown Object (File)
Sat, Apr 13, 2:41 PM
Unknown Object (File)
Thu, Apr 11, 9:18 PM
Unknown Object (File)
Wed, Apr 10, 7:18 AM
Unknown Object (File)
Mon, Apr 8, 9:14 AM
Unknown Object (File)
Sun, Apr 7, 1:18 AM
Unknown Object (File)
Thu, Mar 28, 1:11 PM
Unknown Object (File)
Wed, Mar 27, 8:57 PM
View All 40 Files
Subscribers
machniak
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK094651257b1d: .arclint config
rK629f3f7c7d70: .arclint config
rK3579a26727b6: .arclint config
rK53cbce0e389a: .arclint config
Summary

Includes a linter from https://github.com/appsinet/arc-phpstan (modified
for a 1GB memory limit)

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37951
Build 15337: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jan 12 2022, 12:13 AM
mollekopf created this revision.
Harbormaster completed remote builds in B37951: Diff 9352.Jan 12 2022, 12:13 AM
Harbormaster completed remote builds in B37951: Diff 9352.
mollekopf added a reviewer: Restricted Project.Jan 12 2022, 12:20 AM
mollekopf added a subscriber: Restricted Project.
machniak subscribed.Jan 12 2022, 7:51 AM

I'd prefer .arc folder instead of phabricator.

mollekopf updated this revision to Diff 9406.Jan 18 2022, 2:36 PM

Moved phabricator to .arc

Harbormaster completed remote builds in B38038: Diff 9406.Jan 18 2022, 2:36 PM
machniak added a comment.Jan 25 2022, 2:43 PM

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

.arclint
19

Level=6 is too high, we're using level=4 right now.

mollekopf added a comment.Jan 25 2022, 3:08 PM
In D3289#39604, @machniak wrote:

So, this will execute linting on arc diff? Sounds like it might be annoying, because slow. No?

It's relatively painless because it only lints the diff, not everything.
Also, you can skip it if you really want using --nolint

mollekopf updated this revision to Diff 9463.Jan 25 2022, 5:32 PM

Addressed comments

Harbormaster completed remote builds in B38104: Diff 9463.Jan 25 2022, 5:32 PM
mollekopf marked an inline comment as done.Jan 25 2022, 5:32 PM
machniak accepted this revision.Jan 25 2022, 6:18 PM
This revision is now accepted and ready to land.Jan 25 2022, 6:18 PM
Closed by commit rK094651257b1d: .arclint config (authored by mollekopf). · Explain WhyJan 26 2022, 11:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
3 lines
21 lines
phabricator/
arc-phpstan/
18 lines
lint/
linter/
242 lines

Diff 9352

View Options

.arcconfig

Loading...
View Options

.arclint

Loading...
View Options

phabricator/arc-phpstan/__phutil_library_init__.php

Loading...
View Options

phabricator/arc-phpstan/__phutil_library_map__.php

Loading...
View Options

phabricator/arc-phpstan/lint/linter/PhpstanLinter.php

Loading...