[Python 3] Use print() as function instead of statement
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:37 AM.

Details

Reviewers

machniak
mollekopf

Commits

rPd0579b7e5da3: [Python 3] Use print() as function instead of statement

Summary

print() has been a function since Python 2.6; the old behaviour was
dropped in Python 3.0.

To use the named file argument in Python 2, we need to import
print_function from the future module.

Diff Detail

Repository

rP pykolab

Branch

03-print

Lint

Lint Errors

Severity	Location	Code	Message
Error	cyruslib.py:45	E203	PEP8 E203
Error	cyruslib.py:46	E203	PEP8 E203
Error	cyruslib.py:47	E203	PEP8 E203
Error	cyruslib.py:50	E203	PEP8 E203
Error	cyruslib.py:78	E701	PEP8 E701
Error	cyruslib.py:90	E701	PEP8 E701
Error	cyruslib.py:109	E701	PEP8 E701
Error	cyruslib.py:403	E701	PEP8 E701
Error	cyruslib.py:514	E701	PEP8 E701
Error	cyruslib.py:531	E701	PEP8 E701
Error	cyruslib.py:533	E701	PEP8 E701
Error	cyruslib.py:802	E701	PEP8 E701
Error	cyruslib.py:816	E701	PEP8 E701
Error	cyruslib.py:818	E701	PEP8 E701
Error	ext/python/Tools/freeze/freeze.py:126	E701	PEP8 E701
Error	ext/python/Tools/freeze/freeze.py:329	E701	PEP8 E701
Error	ext/python/Tools/freeze/freeze.py:435	E401	PEP8 E401
Error	ext/python/Tools/freeze/freeze.py:476	E222	PEP8 E222
Error	ext/python/Tools/freeze/makeconfig.py:13	E701	PEP8 E701
Error	ext/python/Tools/freeze/makeconfig.py:21	E228	PEP8 E228
Error	ext/python/Tools/freeze/makefreeze.py:33	E701	PEP8 E701
Error	ext/python/Tools/freeze/winmakemakefile.py:1	E401	PEP8 E401
Error	ext/python/Tools/freeze/winmakemakefile.py:32	E203	PEP8 E203
Error	ext/python/Tools/freeze/winmakemakefile.py:33	E203	PEP8 E203
Error	ext/python/Tools/freeze/winmakemakefile.py:34	E203	PEP8 E203

Unit

No Unit Test Coverage

Build Status

Buildable 37777
Build 15226: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:37 AM

sicherha created this revision.

Harbormaster completed remote builds in B37777: Diff 9196.Jan 8 2022, 11:37 AM

Harbormaster completed remote builds in B37777: Diff 9196.

sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM

mollekopf accepted this revision.Jan 10 2022, 9:53 AM

This revision is now accepted and ready to land.Jan 10 2022, 9:53 AM

This revision was landed with ongoing or failed builds.Jan 10 2022, 8:42 PM

Closed by commit rPd0579b7e5da3: [Python 3] Use print() as function instead of statement (authored by sicherha). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			conf.py (6 lines)
M			cyruslib.py (8 lines)
M			ext/python/Tools/freeze/freeze.py (18 lines)
M			ext/python/Tools/freeze/hello.py (2 lines)
M			ext/python/Tools/freeze/makeconfig.py (4 lines)
M			ext/python/Tools/freeze/makefreeze.py (4 lines)
M			ext/python/Tools/freeze/parsesetup.py (12 lines)
M			ext/python/Tools/freeze/winmakemakefile.py (124 lines)
M			kolab-cli.py (6 lines)
M			pykolab/cli/cmd_add_alias.py (22 lines)
M			pykolab/cli/cmd_add_user_subscription.py (8 lines)
M			pykolab/cli/cmd_check_quota.py (8 lines)
M			pykolab/cli/cmd_count_domain_mailboxes.py (4 lines)
M			pykolab/cli/cmd_delete_mailbox.py (8 lines)
M			pykolab/cli/cmd_delete_mailbox_acl.py (4 lines)
M			pykolab/cli/cmd_export_mailbox.py (6 lines)
M			pykolab/cli/cmd_list_deleted_mailboxes.py (6 lines)
M			pykolab/cli/cmd_list_domain_mailboxes.py (6 lines)
M			pykolab/cli/cmd_list_domains.py (8 lines)
M			pykolab/cli/cmd_list_mailbox_acls.py (8 lines)
M			pykolab/cli/cmd_list_mailbox_metadata.py (10 lines)
M			pykolab/cli/cmd_list_mailboxes.py (4 lines)
M			pykolab/cli/cmd_list_messages.py (12 lines)
M			pykolab/cli/cmd_list_ous.py (2 lines)
M			pykolab/cli/cmd_list_quota.py (30 lines)
M			pykolab/cli/cmd_list_user_subscriptions.py (10 lines)
M			pykolab/cli/cmd_list_users.py (2 lines)
M			pykolab/cli/cmd_remove_mailaddress.py (6 lines)
M			pykolab/cli/cmd_remove_user_subscription.py (18 lines)
M			pykolab/cli/cmd_rename_mailbox.py (10 lines)
M			pykolab/cli/cmd_server_info.py (2 lines)
M			pykolab/cli/cmd_set_mailbox_acl.py (4 lines)
M			pykolab/cli/cmd_set_mailbox_metadata.py (4 lines)
M			pykolab/cli/cmd_set_quota.py (6 lines)
M			pykolab/cli/cmd_sync_mailhost_attrs.py (4 lines)
M			pykolab/cli/cmd_user_info.py (8 lines)
M			pykolab/cli/commands.py (12 lines)
M			pykolab/cli/sieve/cmd_list.py (8 lines)
M			pykolab/cli/sieve/cmd_test.py (18 lines)
M			pykolab/cli/telemetry/cmd_examine_command_issue.py (14 lines)
M			pykolab/cli/telemetry/cmd_examine_session.py (10 lines)
M			pykolab/cli/telemetry/cmd_list_sessions.py (4 lines)
M			pykolab/cli/wap/cmd_system_capabilities.py (6 lines)
M			pykolab/cli/wap/cmd_user_types_list.py (2 lines)
M			pykolab/constants.py.in (2 lines)
M			pykolab/imap/cyrus.py (12 lines)
M			pykolab/imap/dovecot.py (8 lines)
M			pykolab/setup/components.py (12 lines)
M			pykolab/setup/setup_ldap.py (56 lines)
M			pykolab/setup/setup_mysql.py (14 lines)
M			pykolab/setup/setup_php.py (5 lines)
M			pykolab/setup/setup_roundcube.py (10 lines)
M			pykolab/setup/setup_syncroton.py (6 lines)
M			pykolab/wap_client/__init__.py (22 lines)
M			saslauthd.py (6 lines)
M			saslauthd/__init__.py (19 lines)
M			setup-kolab.py (6 lines)
M			tests/functional/test_kolabd/test_001_user_sync.py (2 lines)
M			tests/functional/test_kolabd/test_002_user_rename.py (4 lines)
M			tests/functional/test_wallace/test_002_footer.py (2 lines)
M			tests/functional/test_wallace/test_006_resource_performance.py (4 lines)
M			tests/functional/test_wap_client/test_002_user_add.py (4 lines)
M			tests/functional/test_wap_client/test_003_user_add_fr_FR.py (2 lines)
M			tests/unit/test-008-sievelib.py (2 lines)
M			wallace.py (6 lines)
M			wallace/module_optout.py (2 lines)