Page MenuHomePhorge

Avoid relying on the sender for REPLY attendee matching.
ClosedPublic

Authored by mollekopf on Dec 6 2021, 10:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 14, 11:21 PM
Unknown Object (File)
Sun, Jul 14, 12:38 PM
Unknown Object (File)
Sat, Jul 6, 6:15 PM
Unknown Object (File)
Thu, Jul 4, 9:59 PM
Unknown Object (File)
Fri, Jun 28, 1:07 PM
Unknown Object (File)
Thu, Jun 27, 12:18 PM
Unknown Object (File)
Mon, Jun 24, 3:04 AM
Unknown Object (File)
Sun, Jun 23, 9:38 AM
Subscribers

Details

Summary

This fixes the case where we reply on behalf of someone (e.g. a
resource), and therefore can't use the sender for matching.
For both displaying the itip and processing the reply to update the calendar.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 6 2021, 10:36 AM
machniak subscribed.
machniak added inline comments.
plugins/libcalendaring/lib/libcalendaring_itip.php
1001

A typo.

1008

This will log a warning when $attendee[$email_field] does not exist.

1020

I would filter out attendees without email attribute. Some code expects email to exist, e.g. line 639.

1026

You can remove the else after return.

1029

$itip_attendees should be used here.

This revision now requires changes to proceed.Dec 8 2021, 11:29 AM
mollekopf marked 5 inline comments as done.

Addressed comments

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
This revision is now accepted and ready to land.Dec 17 2021, 1:10 PM
This revision was automatically updated to reflect the committed changes.