Page MenuHomekolab.org

Avoid relying on the sender for REPLY attendee matching.
ClosedPublic

Authored by mollekopf on Dec 6 2021, 10:30 AM.

Details

Summary

This fixes the case where we reply on behalf of someone (e.g. a
resource), and therefore can't use the sender for matching.
For both displaying the itip and processing the reply to update the calendar.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 37268
Build 14918: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Dec 6 2021, 10:30 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 6 2021, 10:36 AM
machniak requested changes to this revision.Dec 8 2021, 11:29 AM
machniak added a subscriber: machniak.
machniak added inline comments.
plugins/libcalendaring/lib/libcalendaring_itip.php
1001

A typo.

1008

This will log a warning when $attendee[$email_field] does not exist.

1020

I would filter out attendees without email attribute. Some code expects email to exist, e.g. line 639.

1026

You can remove the else after return.

1029

$itip_attendees should be used here.

This revision now requires changes to proceed.Dec 8 2021, 11:29 AM
mollekopf updated this revision to Diff 8861.Dec 16 2021, 3:27 PM
mollekopf marked 5 inline comments as done.

Addressed comments

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
mollekopf reopened this revision.Dec 17 2021, 12:28 PM
mollekopf updated this revision to Diff 8915.Dec 17 2021, 12:30 PM

Addressed comments

machniak accepted this revision.Dec 17 2021, 1:10 PM
This revision is now accepted and ready to land.Dec 17 2021, 1:10 PM
This revision was automatically updated to reflect the committed changes.