Page MenuHomePhorge

Update sabre/vobject to version 4.3.5 Increase php version to 5.5
AbandonedPublic

Authored by Jodli on Sep 11 2021, 10:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 11, 4:06 AM
Unknown Object (File)
Sat, Jul 6, 4:54 PM
Unknown Object (File)
Thu, Jul 4, 5:51 AM
Unknown Object (File)
Tue, Jul 2, 1:34 PM
Unknown Object (File)
Sun, Jun 16, 5:08 PM
Unknown Object (File)
Jun 13 2024, 2:33 PM
Unknown Object (File)
Jun 13 2024, 1:14 PM
Unknown Object (File)
Jun 9 2024, 1:14 AM
Subscribers
None

Details

Reviewers
machniak

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
vobject_4.3.5
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36568
Build 14518: arc lint + arc unit

Event Timeline

Jodli created this revision.

If we drop PHP 5.4 support, we can as well drop PHP5 at all, I guess.

plugins/libcalendaring/lib/Horde_Date_Recurrence.php
1568

Checking just for instanceof DateTimeInterface would work too, and be shorter. No?

plugins/libcalendaring/libvcalendar.php
152

We have use \Sabre\VObject in the file, so it should work without this change. Maybe the leading backslash is a problem?

This revision now requires changes to proceed.Oct 25 2021, 9:16 AM

Outdated. We're already using "~4.5.1".