Page MenuHomePhorge

Update sabre/vobject to version 4.3.5 Increase php version to 5.5
AbandonedPublic

Authored by Jodli on Sep 11 2021, 10:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 5:37 AM
Unknown Object (File)
Mon, May 20, 5:31 AM
Unknown Object (File)
Thu, May 2, 12:10 AM
Unknown Object (File)
Tue, Apr 30, 11:00 AM
Unknown Object (File)
Sat, Apr 27, 6:26 AM
Unknown Object (File)
Apr 22 2024, 8:47 PM
Unknown Object (File)
Apr 22 2024, 8:45 PM
Unknown Object (File)
Apr 22 2024, 8:44 PM
Subscribers
None

Details

Reviewers
machniak

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
vobject_4.3.5
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36568
Build 14518: arc lint + arc unit

Event Timeline

Jodli created this revision.

If we drop PHP 5.4 support, we can as well drop PHP5 at all, I guess.

plugins/libcalendaring/lib/Horde_Date_Recurrence.php
1568

Checking just for instanceof DateTimeInterface would work too, and be shorter. No?

plugins/libcalendaring/libvcalendar.php
152

We have use \Sabre\VObject in the file, so it should work without this change. Maybe the leading backslash is a problem?

This revision now requires changes to proceed.Oct 25 2021, 9:16 AM

Outdated. We're already using "~4.5.1".