Page MenuHomePhorge
Differential D2866

Update sabre/vobject to version 4.3.5 Increase php version to 5.5
AbandonedPublic
Actions

Authored by Jodli on Sep 11 2021, 10:10 AM.
Tags
None
Referenced Files
F10600681: D2866.id8239.diff
Mon, Dec 4, 3:54 PM
Unknown Object (File)
Sun, Dec 3, 10:47 PM
Unknown Object (File)
Sat, Dec 2, 6:53 AM
Unknown Object (File)
Fri, Dec 1, 12:31 PM
Unknown Object (File)
Thu, Nov 23, 6:05 PM
Unknown Object (File)
Tue, Nov 21, 12:41 AM
Unknown Object (File)
Sun, Nov 12, 6:18 AM
Unknown Object (File)
Nov 2 2023, 11:23 AM
View All 12 Files
Subscribers
None

Details

Reviewers
machniak

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
vobject_4.3.5
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36568
Build 14518: arc lint + arc unit

Event Timeline

Jodli requested review of this revision.Sep 11 2021, 10:10 AM
Jodli created this revision.
Harbormaster completed remote builds in B36568: Diff 8239.Sep 11 2021, 10:10 AM
sicherha added a reviewer: machniak.Oct 24 2021, 9:19 PM
machniak requested changes to this revision.Oct 25 2021, 9:16 AM

If we drop PHP 5.4 support, we can as well drop PHP5 at all, I guess.

plugins/libcalendaring/lib/Horde_Date_Recurrence.php
1568

Checking just for instanceof DateTimeInterface would work too, and be shorter. No?

plugins/libcalendaring/libvcalendar.php
152

We have use \Sabre\VObject in the file, so it should work without this change. Maybe the leading backslash is a problem?

This revision now requires changes to proceed.Oct 25 2021, 9:16 AM
machniak abandoned this revision.Sep 19 2023, 2:24 PM

Outdated. We're already using "~4.5.1".

Revision Contents
Changeset List

Diff 8239

View Options

plugins/libcalendaring/composer.json

Loading...
View Options

plugins/libcalendaring/lib/Horde_Date.php

Loading...
View Options

plugins/libcalendaring/lib/Horde_Date_Recurrence.php

Loading...
View Options

plugins/libcalendaring/lib/libcalendaring_itip.php

Loading...
View Options

plugins/libcalendaring/lib/libcalendaring_recurrence.php

Loading...
View Options

plugins/libcalendaring/libcalendaring.php

Loading...
View Options

plugins/libcalendaring/libvcalendar.php

Loading...