Greylist/Request: Avoid unnecessary queries
ClosedPublic
Actions

Authored by mollekopf on Aug 27 2021, 10:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 14, 2:05 PM

	Unknown Object (File)
	Fri, Jun 28, 6:20 PM

	Unknown Object (File)
	Fri, Jun 28, 5:45 AM

	Unknown Object (File)
	Fri, Jun 28, 2:40 AM

	Unknown Object (File)
	Fri, Jun 28, 2:35 AM

	Unknown Object (File)
	Jun 26 2024, 8:34 AM

	Unknown Object (File)
	Jun 25 2024, 10:29 AM

	Unknown Object (File)
	Jun 24 2024, 10:23 PM

View All 62 Files

Subscribers

None

Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rKb869129bc47a: Greylist/Request: Avoid unnecessary queries

Summary

Instead of sorting and all entires we can just check if any exists
Instead of inserting and then updating later on, we can just insert at the end.

Diff Detail

Repository

rK kolab

Branch

dev/mollekopf

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 36484
Build 14479: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Aug 27 2021, 10:12 AM

mollekopf created this revision.

Harbormaster completed remote builds in B36469: Diff 8155.Aug 27 2021, 10:12 AM

mollekopf added a reviewer: Restricted Project.Aug 27 2021, 10:12 AM

Avoid the unnecessary insert + update

Harbormaster completed remote builds in B36484: Diff 8167.Aug 27 2021, 10:27 AM

vanmeeuwen accepted this revision.Aug 27 2021, 10:48 AM

This revision is now accepted and ready to land.Aug 27 2021, 10:48 AM

Closed by commit rKb869129bc47a: Greylist/Request: Avoid unnecessary queries (authored by mollekopf). · Explain WhyAug 27 2021, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Policy/

Greylist/

Request.php

27 lines

Diff 8167

View Options

src/app/Policy/Greylist/Request.php

Greylist/Request: Avoid unnecessary queriesClosedPublicActions