Page MenuHomekolab.org
Differential D2839

Greylist/Request: Avoid unnecessary queries
ClosedPublic
Actions

Authored by mollekopf on Aug 27 2021, 10:12 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKb869129bc47a: Greylist/Request: Avoid unnecessary queries
Summary
  • Instead of sorting and all entires we can just check if any exists
  • Instead of inserting and then updating later on, we can just insert at the end.

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 36469
Build 14473: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Aug 27 2021, 10:12 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Aug 27 2021, 10:12 AM
mollekopf updated this revision to Diff 8167.Aug 27 2021, 10:27 AM
mollekopf retitled this revision from Greylist/Request performance enhancement to Greylist/Request: Avoid unnecessary queries.
mollekopf edited the summary of this revision. (Show Details)

Avoid the unnecessary insert + update

vanmeeuwen accepted this revision.Aug 27 2021, 10:48 AM
This revision is now accepted and ready to land.Aug 27 2021, 10:48 AM
Closed by commit rKb869129bc47a: Greylist/Request: Avoid unnecessary queries (authored by mollekopf). · Explain WhyAug 27 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8155

View Options

src/app/Policy/Greylist/Request.php

Loading...