And use tenant-specific app.name also in PaymentsController
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK9c0964980d2f: Add possibility to change system currency
./phpunit
Diff Detail
- Repository
- rK kolab
- Branch
- dev/currency
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 36028 Build 14125: arc lint + arc unit
Event Timeline
Looks good except for the array_merge question
src/app/Providers/Payment/Mollie.php | ||
---|---|---|
586 | Can array_merge handle a non-existing $eurMethods in the $currency == 'EUR' case? Otherwise set to [] |
I'm planning on updating this diff with a fix for stats (where the income chart should sum up eur and chf payments using conversion rates and present the results in chf).
src/app/Providers/Payment/Mollie.php | ||
---|---|---|
586 | I don't get the question. If $currency == 'EUR' array_merge is not executed, because the first request to mollie will return them. |
src/app/Http/Controllers/API/V4/Admin/StatsController.php | ||
---|---|---|
369 ↗ | (On Diff #7732) | applyTenantScope() is implemented in API/V4/Reseller/StatsController. Here it can be empty (until we implement tenant selector for admin stats). For now admins work without the tenant scope, resellers work in their tenant scope. |
388 ↗ | (On Diff #7732) | I'm not sure I get the question. Admin work in system currency. Resellers work in their tenant currency, which is their wallet currency. Note that right now it does not really matter, as we do not have Income chart implementation for resellers (yet). |