On promotion to publisher display the media setup dialog
ClosedPublic
Actions

Authored by machniak on Feb 3 2021, 3:16 PM.

Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK5cc28b459b1c: On promotion to publisher display the media setup dialog

Test Plan

./phpunit tests/Browser/Meet

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Feb 3 2021, 3:16 PM

machniak created this revision.

Harbormaster completed remote builds in B33094: Diff 6211.Feb 3 2021, 3:16 PM

More of a question than a request for further changes.

src/resources/js/meet/app.js
826	You mean, if the user previously denied the permission to media, right?

This revision now requires changes to proceed.Feb 3 2021, 3:57 PM

machniak added inline comments.Feb 3 2021, 4:18 PM

src/resources/js/meet/app.js
826	If user denied access to the media he will not be asked again. This requires a page refresh. If user gave access to media before, in Firefox he's being asked again, in Chrome he isn't.

Addressing the user being more likely to deny permissions, therefore locking themselves out of participation is a challenge that is most likely best resolved with the "everyone's a subscriber" option.

This revision is now accepted and ready to land.Feb 4 2021, 11:40 AM

Closed by commit rK5cc28b459b1c: On promotion to publisher display the media setup dialog (authored by machniak, committed by vanmeeuwen). · Explain WhyFeb 4 2021, 11:41 AM

This revision was automatically updated to reflect the committed changes.