Page MenuHomePhorge
Differential D2032

Remove User::addEntitlement()
ClosedPublic
Actions

Authored by machniak on Dec 31 2020, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 9:31 AM
Unknown Object (File)
Mar 5 2024, 8:47 PM
Unknown Object (File)
Feb 16 2024, 11:20 AM
Unknown Object (File)
Feb 1 2024, 1:46 AM
Unknown Object (File)
Jan 30 2024, 7:00 AM
Unknown Object (File)
Jan 9 2024, 11:58 PM
Unknown Object (File)
Jan 2 2024, 8:55 PM
Unknown Object (File)
Jan 1 2024, 8:52 AM
View All 19 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKc985f174fdfd: Remove User::addEntitlement()
Summary
  • The method is used nowhere and looks quite useless
  • Re-activate and fix some stripe tests, fix phpstan errors
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/remove-addentitlement
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32341
Build 12463: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Dec 31 2020, 9:36 AM
machniak created this revision.
Harbormaster completed remote builds in B32341: Diff 5572.Dec 31 2020, 9:36 AM
vanmeeuwen accepted this revision.Dec 31 2020, 1:07 PM
This revision is now accepted and ready to land.Dec 31 2020, 1:07 PM
Closed by commit rKc985f174fdfd: Remove User::addEntitlement() (authored by machniak, committed by vanmeeuwen). · Explain WhyDec 31 2020, 1:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
7 lines
tests/
Browser/
Meet/
3 lines
Feature/
Controller/
4 lines
34 lines
34 lines
4 lines

Diff 5572

View Options

src/app/User.php

Loading...
View Options

src/tests/Browser/Meet/RoomControlsTest.php

Loading...
View Options

src/tests/Feature/Controller/PaymentsStripeTest.php

Loading...
View Options

src/tests/Feature/EntitlementTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...
View Options

src/tests/StripeMockClient.php

Loading...