Page MenuHomePhorge
Differential D1936

Use a single error code for all room joining error responses
ClosedPublic
Actions

Authored by machniak on Dec 16 2020, 1:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 12:12 AM
Unknown Object (File)
Tue, Apr 9, 8:59 AM
Unknown Object (File)
Sun, Apr 7, 9:28 PM
Unknown Object (File)
Sat, Apr 6, 5:20 AM
Unknown Object (File)
Feb 26 2024, 4:16 AM
Unknown Object (File)
Feb 9 2024, 12:55 PM
Unknown Object (File)
Jan 21 2024, 12:48 AM
Unknown Object (File)
Jan 17 2024, 1:54 AM
View All 21 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKf97a23b0992e: Use a single error code for all room joining error responses
Summary

Fixed unrelated browser test regressions

Test Plan

./phpunit --group=openvidu

Diff Detail

Repository
rK kolab
Branch
dev/meet-error-codes
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32119
Build 12295: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Dec 16 2020, 1:30 PM
machniak created this revision.
Harbormaster completed remote builds in B32119: Diff 5356.Dec 16 2020, 1:30 PM
vanmeeuwen accepted this revision.Dec 16 2020, 1:37 PM
This revision is now accepted and ready to land.Dec 16 2020, 1:37 PM
Closed by commit rKf97a23b0992e: Use a single error code for all room joining error responses (authored by machniak). · Explain WhyDec 16 2020, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
16 lines
resources/
vue/
Meet/
38 lines
Widgets/
4 lines
tests/
Browser/
Meet/
6 lines
8 lines
5 lines
Feature/
Controller/
50 lines

Diff 5356

View Options

src/app/Http/Controllers/API/V4/OpenViduController.php

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/resources/vue/Widgets/StatusMessage.vue

Loading...
View Options

src/tests/Browser/Meet/RoomControlsTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSecurityTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSetupTest.php

Loading...
View Options

src/tests/Feature/Controller/OpenViduTest.php

Loading...