Page MenuHomePhorge

Greylisting/SPF UI
AbandonedPublic

Authored by machniak on Nov 19 2020, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 7:54 AM
Unknown Object (File)
Wed, Mar 6, 12:29 PM
Unknown Object (File)
Feb 14 2024, 2:31 PM
Unknown Object (File)
Feb 13 2024, 11:52 AM
Unknown Object (File)
Jan 9 2024, 2:38 PM
Unknown Object (File)
Dec 29 2023, 8:01 AM
Unknown Object (File)
Dec 26 2023, 11:13 PM
Unknown Object (File)
Nov 21 2023, 4:50 PM
Subscribers
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK0f7eddbb84a0: Greylisting/SPF UI
rK5e8a134c1e40: Greylisting/SPF UI
Summary

User/Domain Settings tabs in user and admin UI

TODO:

  • saving/fetching settings in/from DB, see UserConfigTrait/DomainConfigTrait
  • tests

Diff Detail

Repository
rK kolab
Branch
dev/spf-ui
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31933
Build 12175: arc lint + arc unit

Event Timeline

machniak created this revision.

I'm not seeing why this can not simply use the existing settings trait (and therefore be database backed), would you care to elaborate?

I didn't think about where to store the settings, but still I like to have the settings/configuration input validation code in some place (and not in the controller). This way the controller can be simple and when we need to add more settings we have a separate place to do this without messing with controllers and model classes.

  • Add domain settings, and fix some db structure issues
  • Store spf/greylisting settings in user/domain settings
  • Add tests, rename spf -> spf_whitelist
  • Added browser tests

Abandoned in favor of the combined diff at D2434