Page MenuHomekolab.org

Greylisting/SPF UI
Needs ReviewPublic

Authored by machniak on Thu, Nov 19, 12:42 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

User/Domain Settings tabs in user and admin UI

TODO:

  • saving/fetching settings in/from DB, see UserConfigTrait/DomainConfigTrait
  • tests

Diff Detail

Repository
rK kolab
Branch
dev/spf-ui
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31933
Build 12175: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Thu, Nov 19, 12:42 PM
machniak created this revision.

I'm not seeing why this can not simply use the existing settings trait (and therefore be database backed), would you care to elaborate?

I didn't think about where to store the settings, but still I like to have the settings/configuration input validation code in some place (and not in the controller). This way the controller can be simple and when we need to add more settings we have a separate place to do this without messing with controllers and model classes.

machniak updated this revision to Diff 5191.Mon, Nov 23, 3:34 PM
  • Add domain settings, and fix some db structure issues
  • Store spf/greylisting settings in user/domain settings
  • Add tests, rename spf -> spf_whitelist
  • Added browser tests