Also adds doctum
Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKe53988be889e: Restructure user and domain jobs
./phpunit
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/T380774
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 31189 Build 11743: arc lint + arc unit
Event Timeline
| src/app/Http/Controllers/API/V4/UsersController.php | ||
|---|---|---|
| 598 | This will have to call fresh()/refresh() on the $user. | |
| 605 | This will have to call fresh()/refresh() on the $user. | |
| src/app/Jobs/Domain/UpdateJob.php | ||
| 18 | The same as in User/UpdateJob, we should check if the domain isLdapReady() here, and maybe if it's not deleted/trashed(). Actually all domain jobs should check if the domain is not yet deleted. | |
| src/tests/Feature/Documents/ReceiptTest.php | ||
| 22 | You can just Payment::whereIn('id', $paymentIDs)->delete(). Also, you should do the same in teardown. I guess this might be why the stripe test failed. | |
Comment Actions
- Verify a user's domain is ldapready before attempting to create the user. Return the job to the queue with a 60 second delay if the domain is not ready