Page MenuHomekolab.org

Restructure user and domain jobs
ClosedPublic

Authored by vanmeeuwen on Oct 7 2020, 2:38 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKe53988be889e: Restructure user and domain jobs
Summary

Also adds doctum

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/T380774
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31189
Build 11743: arc lint + arc unit

Event Timeline

vanmeeuwen requested review of this revision.Oct 7 2020, 2:38 PM
vanmeeuwen created this revision.
machniak requested changes to this revision.Oct 7 2020, 2:57 PM
machniak added a subscriber: machniak.
machniak added inline comments.
src/app/Http/Controllers/API/V4/UsersController.php
598

This will have to call fresh()/refresh() on the $user.

605

This will have to call fresh()/refresh() on the $user.

src/app/Jobs/Domain/UpdateJob.php
18

The same as in User/UpdateJob, we should check if the domain isLdapReady() here, and maybe if it's not deleted/trashed(). Actually all domain jobs should check if the domain is not yet deleted.

src/tests/Feature/Documents/ReceiptTest.php
22

You can just Payment::whereIn('id', $paymentIDs)->delete(). Also, you should do the same in teardown. I guess this might be why the stripe test failed.

This revision now requires changes to proceed.Oct 7 2020, 2:57 PM
vanmeeuwen updated this revision to Diff 4600.Oct 7 2020, 2:57 PM
  • Verify a user's domain is ldapready before attempting to create the user. Return the job to the queue with a 60 second delay if the domain is not ready
vanmeeuwen updated this revision to Diff 4606.Oct 7 2020, 3:05 PM
vanmeeuwen marked 4 inline comments as done.
  • Improve based on feedback

Marking comments as done

machniak accepted this revision.Oct 7 2020, 3:12 PM
This revision is now accepted and ready to land.Oct 7 2020, 3:12 PM
This revision was automatically updated to reflect the committed changes.