Page MenuHomePhorge

Better structure for console commands, and unification of code/behavior
AbandonedPublic

Authored by machniak on Oct 2 2020, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 6:46 PM
Unknown Object (File)
Fri, Mar 1, 7:57 AM
Unknown Object (File)
Feb 10 2024, 5:05 AM
Unknown Object (File)
Jan 29 2024, 6:48 AM
Unknown Object (File)
Jan 29 2024, 12:11 AM
Unknown Object (File)
Jan 19 2024, 12:36 PM
Unknown Object (File)
Jan 19 2024, 1:28 AM
Unknown Object (File)
Jan 15 2024, 2:38 PM
Subscribers
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/cli-refactor
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31081
Build 11650: arc lint + arc unit

Event Timeline

machniak created this revision.

We're just taking note of some of the restructuring here, largely agreeable, and then I'll counter-propose an approach for review on Monday.

src/app/Console/Commands/Domain/SetStatus.php
35

In any command line, it is important to consider that should some stdout or stderr be rendered, it is accurate to the occasion for which it is rendered.

This should therefore be: Domain {$this->argument('domain')} not found (if that is syntactically valid.