Page MenuHomekolab.org

Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try to properly detect when XFER command should be issued
ClosedPublic

Authored by machniak on May 4 2016, 11:23 AM.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 314.May 4 2016, 11:23 AM
machniak retitled this revision from to Fix folder name encodin issues in undelete-mailbox (#5299) Additionally, try to properly detect when XFER command should be issued.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 4:49 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen added a subscriber: vanmeeuwen.

Please see inline commentary.

pykolab/imap/cyrus.py
344–345

Why not move this up to outside the dry-run clause, and use the same if not target_server == source_server clause for the dry-run section?

This revision now requires changes to proceed.May 4 2016, 4:49 PM
machniak added inline comments.May 4 2016, 6:16 PM
pykolab/imap/cyrus.py
344–345

I missed that part, will fix it

machniak updated this revision to Diff 328.May 4 2016, 6:19 PM
machniak edited edge metadata.

Fix setting source folder also for dry-run mode

vanmeeuwen accepted this revision.May 6 2016, 2:23 PM
vanmeeuwen edited edge metadata.

Thanks

This revision is now accepted and ready to land.May 6 2016, 2:23 PM
This revision was automatically updated to reflect the committed changes.