Page MenuHomePhorge
Differential D1516

Fix editing (and saving) existing entries in a list input widget
ClosedPublic
Actions

Authored by machniak on Aug 20 2020, 3:54 PM.
Tags
None
Referenced Files
F11822256: D1516.id3952.diff
Sat, Apr 20, 8:29 AM
Unknown Object (File)
Wed, Apr 10, 11:08 PM
Unknown Object (File)
Wed, Apr 10, 5:53 AM
Unknown Object (File)
Tue, Apr 9, 3:33 AM
Unknown Object (File)
Sun, Apr 7, 11:19 AM
Unknown Object (File)
Sat, Apr 6, 4:00 PM
Unknown Object (File)
Wed, Apr 3, 3:34 PM
Unknown Object (File)
Fri, Mar 29, 5:24 AM
View All 33 Files
Subscribers
bohlender
Restricted Project

Details

Reviewers
bohlender
Group Reviewers
Restricted Project
Commits
rK219da883698e: Fix editing (and saving) existing entries in a list input widget

Diff Detail

Repository
rK kolab
Branch
dev/listinput-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30202
Build 11278: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Aug 20 2020, 3:54 PM
machniak created this revision.
Harbormaster completed remote builds in B30196: Diff 3946.Aug 20 2020, 3:54 PM
machniak updated this revision to Diff 3952.Aug 20 2020, 4:13 PM
  • Fix corner case in email address validation
Harbormaster completed remote builds in B30202: Diff 3952.Aug 20 2020, 4:13 PM
bohlender accepted this revision.Aug 27 2020, 9:10 AM
bohlender subscribed.

looks good to me. there is a remaining UX issue. during the usetest, people entered something in the first line without hitting the "plus" button and expected their changes to be saved but that is out of scope for this.

This revision is now accepted and ready to land.Aug 27 2020, 9:10 AM
Closed by commit rK219da883698e: Fix editing (and saving) existing entries in a list input widget (authored by machniak). · Explain WhyAug 27 2020, 10:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
4 lines
resources/
vue/
Widgets/
2 lines
tests/
Browser/
23 lines
Feature/
Controller/
12 lines

Diff 3952

View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/resources/vue/Widgets/ListInput.vue

Loading...
View Options

src/tests/Browser/UsersTest.php

Loading...
View Options

src/tests/Feature/Controller/UsersTest.php

Loading...