Page MenuHomekolab.org

Fix editing (and saving) existing entries in a list input widget
ClosedPublic

Authored by machniak on Aug 20 2020, 3:54 PM.

Details

Diff Detail

Repository
rK kolab
Branch
dev/listinput-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30196
Build 11272: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Aug 20 2020, 3:54 PM
machniak created this revision.
machniak updated this revision to Diff 3952.Aug 20 2020, 4:13 PM
  • Fix corner case in email address validation
bohlender accepted this revision.Aug 27 2020, 9:10 AM
bohlender added a subscriber: bohlender.

looks good to me. there is a remaining UX issue. during the usetest, people entered something in the first line without hitting the "plus" button and expected their changes to be saved but that is out of scope for this.

This revision is now accepted and ready to land.Aug 27 2020, 9:10 AM
This revision was automatically updated to reflect the committed changes.