Page MenuHomePhorge

Establish a month of free trial
ClosedPublic

Authored by vanmeeuwen on Aug 20 2020, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 7:32 AM
Unknown Object (File)
Sun, Mar 17, 2:52 AM
Unknown Object (File)
Wed, Mar 13, 11:07 AM
Unknown Object (File)
Feb 23 2024, 8:59 AM
Unknown Object (File)
Feb 22 2024, 5:02 PM
Unknown Object (File)
Feb 21 2024, 9:25 PM
Unknown Object (File)
Feb 19 2024, 2:52 PM
Unknown Object (File)
Feb 19 2024, 1:00 PM
Subscribers
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK368428f6d299: Establish a month of free trial
Summary
  • New registrations get all the bells and whistles
  • Do not bill entitlement's first month compared against the wallet's creation date
Test Plan

None

Diff Detail

Repository
rK kolab
Branch
arcpatch-D1504
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30904
Build 11503: arc lint + arc unit

Event Timeline

vanmeeuwen created this revision.
machniak subscribed.
  1. Tests
  2. It will not create transaction records when $charges=0. See debit().
  3. So, if you rise your quota on the day after signup, it will not be free. I.e. free are only the default entitlement. Maybe that's good and maybe it will need some faq entry?
This revision now requires changes to proceed.Aug 20 2020, 12:38 PM
  1. Tests
  2. It will not create transaction records when $charges=0. See debit().
  3. So, if you rise your quota on the day after signup, it will not be free. I.e. free are only the default entitlement. Maybe that's good and maybe it will need some faq entry?

You would first hit 83, but yeah, maybe it's better to yet again compare not isSameDay but diffInMonths() <= 1 or something.

  • Move forward any entitlements if we find the wallet is in the first month

Rebase on current master;

  • Move forward any entitlements if we find the wallet is in the first month
  • Apply the first free month trial period, here too
src/app/Wallet.php
64

Maybe it should be $this->owner->created_at? In case this is a second wallet created later.

This revision is now accepted and ready to land.Sep 23 2020, 11:53 AM
This revision was automatically updated to reflect the committed changes.