A user should have the possibility to only set a different domainname and not a
full sieve url. If no protocoll is set, than it is used as domainname.
Details
Details
- Reviewers
mollekopf - Maniphest Tasks
- T1225: Endless spinner waiting for Sieve Scripts
- Commits
- rKP8b58f4f4d903: Support only domainname in alternate sieveurl.
Diff Detail
Diff Detail
- Repository
- rKP kdepim
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
libksieve/ksieveui/util/util.cpp | ||
---|---|---|
119 | This will clear the port even if it's set. So in this setup you'd even have to specify the whole magic string, or hope that the default port is correct. Please keep the port even if the protocol is empty. |
Comment Actions
Move the fixing logic is in the resource directly and this function only prints out that it is an invalid sieve url.
libksieve/ksieveui/util/util.cpp | ||
---|---|---|
119 | kFatal will crash the application, definitely not what we want. |
libksieve/ksieveui/util/util.cpp | ||
---|---|---|
119 | Perhaps kWarning and return KUrl(); |