Page MenuHomePhorge

Support only domainname in alternate sieveurl.
ClosedPublic

Authored by knauss on Apr 27 2016, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 4:48 PM
Unknown Object (File)
Sat, Mar 2, 4:47 PM
Unknown Object (File)
Sat, Mar 2, 4:47 PM
Unknown Object (File)
Sat, Mar 2, 4:47 PM
Unknown Object (File)
Sat, Mar 2, 4:47 PM
Unknown Object (File)
Feb 15 2024, 11:44 AM
Unknown Object (File)
Feb 8 2024, 8:44 PM
Unknown Object (File)
Jan 25 2024, 3:40 AM
Subscribers
None

Details

Summary

A user should have the possibility to only set a different domainname and not a
full sieve url. If no protocoll is set, than it is used as domainname.

Diff Detail

Repository
rKP kdepim
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

knauss retitled this revision from to Support only domainname in alternate sieveurl..
knauss updated this object.
knauss added a reviewer: mollekopf.
mollekopf edited edge metadata.
mollekopf added inline comments.
libksieve/ksieveui/util/util.cpp
119

This will clear the port even if it's set. So in this setup you'd even have to specify the whole magic string, or hope that the default port is correct. Please keep the port even if the protocol is empty.

This revision now requires changes to proceed.Apr 28 2016, 12:04 PM
libksieve/ksieveui/util/util.cpp
119

moved this logic about fixing the alternateURL to the writer in kdepim-runtime, this makes it much more easier to handle it correctly. See D148

knauss edited edge metadata.

Move the fixing logic is in the resource directly and this function only prints out that it is an invalid sieve url.

mollekopf edited edge metadata.
mollekopf added inline comments.
libksieve/ksieveui/util/util.cpp
119

kFatal will crash the application, definitely not what we want.

This revision now requires changes to proceed.Apr 28 2016, 11:59 PM
libksieve/ksieveui/util/util.cpp
119

Perhaps kWarning and return KUrl();

knauss edited edge metadata.

Fixed issue raised by Christian

mollekopf edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 12:12 PM
This revision was automatically updated to reflect the committed changes.