Page MenuHomekolab.org

Support only domainname in alternate sieveurl.
ClosedPublic

Authored by knauss on Apr 27 2016, 4:28 PM.

Details

Summary

A user should have the possibility to only set a different domainname and not a
full sieve url. If no protocoll is set, than it is used as domainname.

Diff Detail

Repository
rKP kdepim
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

knauss updated this revision to Diff 295.Apr 27 2016, 4:28 PM
knauss retitled this revision from to Support only domainname in alternate sieveurl..
knauss updated this object.
knauss added a reviewer: mollekopf.
mollekopf requested changes to this revision.Apr 28 2016, 12:04 PM
mollekopf edited edge metadata.
mollekopf added inline comments.
libksieve/ksieveui/util/util.cpp
119

This will clear the port even if it's set. So in this setup you'd even have to specify the whole magic string, or hope that the default port is correct. Please keep the port even if the protocol is empty.

This revision now requires changes to proceed.Apr 28 2016, 12:04 PM
knauss added inline comments.Apr 28 2016, 7:47 PM
libksieve/ksieveui/util/util.cpp
119

moved this logic about fixing the alternateURL to the writer in kdepim-runtime, this makes it much more easier to handle it correctly. See D148

knauss updated this revision to Diff 300.Apr 28 2016, 7:48 PM
knauss edited edge metadata.

Move the fixing logic is in the resource directly and this function only prints out that it is an invalid sieve url.

mollekopf requested changes to this revision.Apr 28 2016, 11:59 PM
mollekopf edited edge metadata.
mollekopf added inline comments.
libksieve/ksieveui/util/util.cpp
119

kFatal will crash the application, definitely not what we want.

This revision now requires changes to proceed.Apr 28 2016, 11:59 PM
mollekopf added inline comments.Apr 29 2016, 12:13 AM
libksieve/ksieveui/util/util.cpp
119

Perhaps kWarning and return KUrl();

knauss updated this revision to Diff 305.Apr 29 2016, 11:58 AM
knauss edited edge metadata.

Fixed issue raised by Christian

mollekopf accepted this revision.Apr 29 2016, 12:12 PM
mollekopf edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 12:12 PM
Closed by commit rKP8b58f4f4d903: Support only domainname in alternate sieveurl. (authored by Sandro Knauß <sknauss@kde.org>). · Explain WhyApr 29 2016, 12:15 PM
This revision was automatically updated to reflect the committed changes.