Page MenuHomekolab.org

Prevent from AttributeError when stopping wallace
ClosedPublic

Authored by machniak on Apr 19 2016, 11:33 AM.

Details

Summary

Sometimes self.pool may not exists when killing wallace process

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 287.Apr 19 2016, 11:33 AM
machniak retitled this revision from to Prevent from AttributeError when stopping wallace.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 3:59 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen added a subscriber: vanmeeuwen.

Let's make sure that self.pool = None instead, and test for self.pool is not None right where you made your changes -- A self.pool that exists can still not have a function .close() / .join().

This revision now requires changes to proceed.May 4 2016, 3:59 PM
machniak updated this revision to Diff 321.May 4 2016, 4:21 PM
machniak edited edge metadata.

Make sure that self.pool = None instead, and test for self.pool is not None

vanmeeuwen accepted this revision.May 13 2016, 10:46 AM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 10:46 AM
This revision was automatically updated to reflect the committed changes.