Fixes T1171
Details
Details
- Reviewers
vanmeeuwen - Group Reviewers
PyKolab Developers - Maniphest Tasks
- T1171: LDAP reconnection does not bind the LDAP user
- Commits
- rPe2342d75e98a: Fix binding current user after LDAP reconnection (T1171)
rP39e31385df84: Fix binding current user after LDAP reconnection (T1171)
rP0ffec36d05c7: Fix binding current user after LDAP reconnection (T1171)
rPa97671344872: Fix binding current user after LDAP reconnection (T1171)
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Branch
- dev/T1171
- Lint
Lint Errors - Unit
No Test Coverage - Build Status
Buildable 3551 Build 3526: arc lint + arc unit
Event Timeline
pykolab/auth/ldap/__init__.py | ||
---|---|---|
1211 | The whole 'else' block here is useless. I propose to remove it and change line 1220 to be: if bind_dn is not None: |
pykolab/auth/ldap/__init__.py | ||
---|---|---|
1211 | I'll take it for cases where it is not reconnect() calling _bind() |
pykolab/auth/ldap/__init__.py | ||
---|---|---|
1211 | But it does not make sense because line 1220 is: if self.bind is None: which iimo is correct, because there's no need to bind a user who is already bound. |