Page MenuHomePhorge

Fix binding current user after LDAP reconnection (T1171)
ClosedPublic

Authored by machniak on Apr 6 2016, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 3:12 PM
Unknown Object (File)
Sun, Mar 17, 10:48 AM
Unknown Object (File)
Tue, Mar 5, 3:00 PM
Unknown Object (File)
Tue, Mar 5, 3:00 PM
Unknown Object (File)
Tue, Mar 5, 3:00 PM
Unknown Object (File)
Sat, Mar 2, 4:36 PM
Unknown Object (File)
Sat, Mar 2, 4:36 PM
Unknown Object (File)
Sat, Mar 2, 4:36 PM
Subscribers
None

Event Timeline

machniak retitled this revision from to Fix binding current user after LDAP reconnection (T1171).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
This revision is now accepted and ready to land.Apr 14 2016, 11:32 AM
This revision was automatically updated to reflect the committed changes.

The state tracking turns out to be invalid.

This revision is now accepted and ready to land.May 4 2016, 2:50 PM
vanmeeuwen edited edge metadata.

def _bind() may inadvertedly return True.

This revision now requires changes to proceed.May 4 2016, 3:44 PM
machniak edited edge metadata.

Fixed rebinding

vanmeeuwen edited reviewers, added: machniak; removed: vanmeeuwen.
vanmeeuwen edited edge metadata.
  • Clean it up and use lesser privileges
  • Clean it up and use lesser privileges
  • Use _unbind() instead
machniak edited edge metadata.
machniak added inline comments.
pykolab/auth/ldap/__init__.py
1211

The whole 'else' block here is useless. I propose to remove it and change line 1220 to be: if bind_dn is not None:

This revision now requires changes to proceed.May 5 2016, 11:31 AM
vanmeeuwen edited edge metadata.
vanmeeuwen marked an inline comment as done.
vanmeeuwen added inline comments.
pykolab/auth/ldap/__init__.py
1211

I'll take it for cases where it is not reconnect() calling _bind()

machniak requested changes to this revision.May 5 2016, 9:08 PM
machniak edited edge metadata.
machniak added inline comments.
pykolab/auth/ldap/__init__.py
1211

But it does not make sense because line 1220 is: if self.bind is None: which iimo is correct, because there's no need to bind a user who is already bound.

This revision now requires changes to proceed.May 5 2016, 9:08 PM
machniak edited reviewers, added: vanmeeuwen; removed: machniak.

Removed useless code, added logging of all bind actions for better debugging

vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 7 2016, 1:05 PM
This revision was automatically updated to reflect the committed changes.