Page MenuHomekolab.org

Fix binding current user after LDAP reconnection (T1171)
ClosedPublic

Authored by machniak on Apr 6 2016, 8:38 PM.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 260.Apr 6 2016, 8:38 PM
machniak retitled this revision from to Fix binding current user after LDAP reconnection (T1171).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen accepted this revision.Apr 14 2016, 11:32 AM
vanmeeuwen added a reviewer: vanmeeuwen.
This revision is now accepted and ready to land.Apr 14 2016, 11:32 AM
This revision was automatically updated to reflect the committed changes.
vanmeeuwen reopened this revision.May 4 2016, 2:50 PM

The state tracking turns out to be invalid.

This revision is now accepted and ready to land.May 4 2016, 2:50 PM
vanmeeuwen requested changes to this revision.May 4 2016, 3:44 PM
vanmeeuwen edited edge metadata.

def _bind() may inadvertedly return True.

This revision now requires changes to proceed.May 4 2016, 3:44 PM
machniak updated this revision to Diff 320.May 4 2016, 4:08 PM
machniak edited edge metadata.

Fixed rebinding

vanmeeuwen commandeered this revision.May 5 2016, 10:57 AM
vanmeeuwen edited reviewers, added: machniak; removed: vanmeeuwen.
vanmeeuwen updated this revision to Diff 329.May 5 2016, 10:57 AM
vanmeeuwen edited edge metadata.
  • Clean it up and use lesser privileges
vanmeeuwen updated this revision to Diff 330.May 5 2016, 10:58 AM
  • Clean it up and use lesser privileges
  • Use _unbind() instead
machniak requested changes to this revision.May 5 2016, 11:31 AM
machniak edited edge metadata.
machniak added inline comments.
pykolab/auth/ldap/__init__.py
1221

The whole 'else' block here is useless. I propose to remove it and change line 1220 to be: if bind_dn is not None:

This revision now requires changes to proceed.May 5 2016, 11:31 AM
vanmeeuwen requested a review of this revision.May 5 2016, 3:17 PM
vanmeeuwen edited edge metadata.
vanmeeuwen marked an inline comment as done.
vanmeeuwen added inline comments.
pykolab/auth/ldap/__init__.py
1221

I'll take it for cases where it is not reconnect() calling _bind()

machniak requested changes to this revision.May 5 2016, 9:08 PM
machniak edited edge metadata.
machniak added inline comments.
pykolab/auth/ldap/__init__.py
1221

But it does not make sense because line 1220 is: if self.bind is None: which iimo is correct, because there's no need to bind a user who is already bound.

This revision now requires changes to proceed.May 5 2016, 9:08 PM
machniak commandeered this revision.May 6 2016, 3:22 PM
machniak edited reviewers, added: vanmeeuwen; removed: machniak.
machniak updated this revision to Diff 336.May 6 2016, 3:22 PM

Removed useless code, added logging of all bind actions for better debugging

vanmeeuwen accepted this revision.May 7 2016, 1:05 PM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 7 2016, 1:05 PM
This revision was automatically updated to reflect the committed changes.