Details

Reviewers

machniak
mollekopf

Group Reviewers

Autoconf Developers

Commits

rACc526e21729a7: reformat error messages

Summary

Send correct error messages depending on the type of autodiscover method. Microsoft == XML Error Message, JSON == json formatted error message. Sending a generic error 500 is harder to debug in the end.

Diff Detail

Repository

rAC autoconf

Branch

error-codes

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28954
Build 10468: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Apr 2 2020, 2:15 AM

dhoffend created this revision.

Harbormaster completed remote builds in B28954: Diff 2899.Apr 2 2020, 2:15 AM

dhoffend edited the summary of this revision. (Show Details)Apr 2 2020, 2:16 AM

fix whitespace

Harbormaster completed remote builds in B28960: Diff 2902.Apr 2 2020, 2:18 AM

machniak requested changes to this revision.Apr 5 2020, 8:26 AM

machniak subscribed.

machniak added inline comments.

lib/AutodiscoverJson.php
124	I guess it should be `ErrorCode`.

This revision now requires changes to proceed.Apr 5 2020, 8:26 AM

fixed typo

Harbormaster completed remote builds in B28996: Diff 2929.Apr 6 2020, 9:50 PM

switch to an error code a real ms server sends out on invalid request

Harbormaster completed remote builds in B28999: Diff 2935.Apr 6 2020, 9:57 PM

You're right. I've fixed the typo and replaced the msxml errorcode with one that a real exchange server sends outs. Just in case something weird could happing.

dhoffend requested review of this revision.Apr 6 2020, 9:59 PM